Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix full group by in search builder when using tags #13504

Closed
wants to merge 1 commit into from

Conversation

mattwire
Copy link
Contributor

Overview

When using search builder and searching by tag only a single contact is displayed in the search results but the count is correct (eg 49). When changing the number of displayed per page a mysql full group by error occurs as there is no group by clause (for contact_a.id).

Example search using demo data:
localhost_8080_civicrm_contact_search_builder__qf_builder_display true qfkey e440a2cdbae102a67e5af63726ae054c_6804

Before

Search builder does not display results properly when searching by tag.

After

Search builder does display results properly when searching by tag.

Technical Details

This is another fullgroupby issue.

Comments

@seamuslee001 Tagging you as the resident fullgroupby expert!

@civibot
Copy link

civibot bot commented Jan 25, 2019

(Standard links)

@civibot civibot bot added the master label Jan 25, 2019
@mattwire
Copy link
Contributor Author

Test failure looks related, but I'm a bit out of my depth now!

@eileenmcnaughton
Copy link
Contributor

@mattwire I think we'd want a test on this one - I'm totally OK with the use of disableFullGroupBy when a query might not support it as a fix as long as it's in conjunction with a test

@mattwire
Copy link
Contributor Author

mattwire commented Feb 5, 2019

Fixed via #13533

@mattwire mattwire closed this Feb 5, 2019
@eileenmcnaughton
Copy link
Contributor

Ah dang I didn't draw the connection with this PR when I was digging into that issue. Anyway I think we are good now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants