Fix full group by in search builder when using tags #13504
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
When using search builder and searching by tag only a single contact is displayed in the search results but the count is correct (eg 49). When changing the number of displayed per page a mysql full group by error occurs as there is no group by clause (for contact_a.id).
Example search using demo data:
Before
Search builder does not display results properly when searching by tag.
After
Search builder does display results properly when searching by tag.
Technical Details
This is another fullgroupby issue.
Comments
@seamuslee001 Tagging you as the resident fullgroupby expert!