Doc fixes and add comments to axi4 bundles #2925
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
IMHO, porting like this makes RC more friendly to newbies, most of them never reads Chisel2 codes before. And Chisel also leaks of compatibility layer docs. |
|
I’m ok with it if and only if some representatives designs are proven equivalent. |
|
Splitting this up into separate PRs to add documentation/upgrade to chisel3 is the way to go. |
jiegec
changed the title
michael-etzkorn
previously approved these changes
May 12, 2022
sequencer
dismissed
michael-etzkorn’s stale review
Don't merge since leaks sufficient tests.
sequencer
requested changes
May 12, 2022
|
Sorry, @michael-etzkorn I just found the author has rebased the PR, but there I do have some nitpick on this, since it needs a deprecation notice and type/function alias for the typo fix. |
jiegec
force-pushed
the
doc-fixes
branch
5 times, most recently
from
886e645 to
da516dd
Compare
This incurs a small breaking change, but can be easily fixed.
sequencer
approved these changes
May 13, 2022
jiegec
force-pushed
the
doc-fixes
branch
2 times, most recently
from
bd85a91 to
d9f5176
Compare
sequencer
added a commit
to sequencer/fpga-shells
that referenced
this pull request
May 13, 2022
sequencer
added a commit
to chipsalliance/rocket-chip-fpga-shells
that referenced
this pull request
Jun 5, 2022
jerryz123
added a commit
to chipsalliance/rocket-chip-fpga-shells
that referenced
this pull request
Sep 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: None
Type of change: other enhancement
Impact: no functional change
Development Phase: implementation
Release Notes
AHPParametersandAPBParameters.