Removed TraceGen in HeterogeneousTileExampleConfig #2923
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
December 27, 2021 21:36
* Examples should be compatible with ExampleRocketSystem * TraceGen examples should be given in groundtest - this might require fixing GroundTestSubsystem's intNode use.
|
Related issue: Some relation to the style guide discussion we had today in the working group since I moved some parentheses to a new line if the config was more than one line. |
hcook
approved these changes
Jul 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue:
Type of change: other enhancement
Impact: API modification
Development Phase: implementation
Release Notes
The
HeterogeneousTileExampleConfigwill not work withExampleRocketSystemorGroundTestSubsystem. Therefore, it should be put firmly into one camp to be congruent with the examples provided.This pull request also makes parentheses stylistically more consistent in
src/main/scala/system/Configs.scala