This repository has been archived by the owner on Aug 20, 2024. It is now read-only.
Make submodule inputs void in ExpandWhens #706
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jackkoenig
force-pushed
the
fix-submodule-invalidate
branch
from
921db1e
to
4350f2f
Compare
8 tasks
colinschmidt
suggested changes
Dec 20, 2017
| case w: DefWire => | ||
| netlist ++= (getFemaleRefs(w.name, w.tpe, BIGENDER) map (ref => we(ref) -> WVoid)) | ||
| w | ||
| case w: DefMemory => | ||
| netlist ++= (getFemaleRefs(w.name, MemPortUtils.memType(w), MALE) map (ref => we(ref) -> WVoid)) | ||
| w | ||
| case w: WDefInstance => | ||
| netlist ++= (getFemaleRefs(w.name, w.tpe, MALE).map(ref => we(ref) -> WVoid)) |
There was a problem hiding this comment.
MALE of getFemaleRefs here means to get all the inputs to the submodule?
There was a problem hiding this comment.
That's correct, similar to how it's used on the DefMemory above.
colinschmidt
approved these changes
Dec 20, 2017
9 tasks
|
Due to chipsalliance/chisel#746 this currently doesn't work with rocket-chip, I am trying to get this fixed tonight |
azidar
approved these changes
Dec 20, 2017
jackkoenig
added a commit
that referenced
this pull request
Dec 20, 2017
This is a modification of #706 to preserve the bugfix but preserve the [buggy] API that firrtl was not properly enforcing initialization requirements for submodule inputs
jackkoenig
added a commit
that referenced
this pull request
Dec 20, 2017
This is a modified form of #706 to preserve the bugfix but preserve the [buggy] 1.0.x API that firrtl was not properly enforcing initialization requirements for submodule inputs
jackkoenig
added a commit
that referenced
this pull request
Dec 21, 2017
This is a modified form of #706 to preserve the bugfix but preserve the [buggy] 1.0.x API that firrtl was not properly enforcing initialization requirements for submodule inputs. If a submodule port is not properly invalidated, ExpandWhens will print a warning.
ucbjrl
added a commit
that referenced
this pull request
Dec 21, 2017
…as 712) This is a modified form of #706 to preserve the bugfix but preserve the [buggy] 1.0.x API that firrtl was not properly enforcing initialization requirements for submodule inputs The problem with #706 is that because Firrtl wasn't properly enforcing initialization requirements on submodules, code that used to work no longer does. This alternative version still fixes the incorrect Verilog generation bug but does not enforce the initialization requirement.
This was referenced Dec 21, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #705
The ports of submodules were not voided in ExpandWhens which means it does not error if they are not properly initialized. Worse still, since they don't have a default value in the netlist, the logic in ExpandWhens just picks the first connection and ignores all the rest.
I've added a test for each of the above cases.