Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Institution Profile pages - Update alert text for missing TIN and LEI #1052

Merged
merged 8 commits into from
Nov 15, 2024

Conversation

meissadia
Copy link
Contributor

@meissadia meissadia commented Nov 8, 2024

Closes #1050

Changes

  • [View] Update alert texts for missing TIN and LEI
  • [View] Update page intro text
  • [View] Update LEI field label
  • [Update] Ensure order: TIN, RSSD ID, Federal regulator
  • [Update] Language updates

How to test this PR

  1. [ViewInstitutionProfile > index.tsx] Replace the data param highlighted in the screenshot below with the following.

    const testBlankValues = {
      lei: 'FI_LEI',
      name: 'FI_INSTITUTION_NAME',
      hq_address_street_1: 'HQ_ADDRESS_STREET_1',
      hq_address_city: 'HQ_ADDRESS_CITY',
      hq_address_state: 'HQ_ADDRESS_STATE',
      hq_address_state_code: 'HQ_ADDRESS_STATE_CODE',
      hq_address_zip: 'HQ_ADDRESS_ZIP',
    };
    
    Screenshot 2024-10-22 at 2 03 45 PM
  2. Visit the Institution profile page

Screenshots

View institution profile

InstitutionProfile-view

Update institution profile

InstitutionProfile-update

@meissadia meissadia marked this pull request as ready for review November 8, 2024 20:26
@meissadia meissadia changed the title View Institution Profile - Update alert text for missing TIN and LEI Institution Profile pages - Update alert text for missing TIN and LEI Nov 14, 2024
@natalia-fitzgerald
Copy link

natalia-fitzgerald commented Nov 14, 2024

@meissadia
Let me know whether any of these changes will be handled separately from this PR and I can approve the PR with a note referencing these issues (I assume this would apply to the width of the field-level alert and maybe the external link icon).

Here's a list of changes:

Already discussed in our call:

  • Width of field-level alert text should max out at 670px

Found in my review of the latest screenshots:

  • Add external link icon to GLEIF reference
  • VIEW PAGE -- Spell out "Local Operating Unit (LOU)" in the "Parent entity information (if applicable)" section
  • UPDATE PAGE -- Update the text block before "Type of financial institution" to "Select all applicable types of financial institutions from the list below. If the enumerated types do not appropriately describe your financial institution, or if you wish to add additional types, select "Other" and add your entry to the text field."

@meissadia
Copy link
Contributor Author

meissadia commented Nov 15, 2024

@natalia-fitzgerald

Will be separate:

  • Alert width
  • External link icons within an Alert

View - Language for intro to Parent info section

intro-parent-entity

Update - Intro to Types of FI

intro-fi-types

Copy link

@natalia-fitzgerald natalia-fitzgerald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@meissadia
Looks good! I have reviewed the screenshots and they look good. All changes appear to be accounted for with the exception of the items that you have mentioned will be handled separately (Alert width
External link icons within an Alert).

@meissadia meissadia merged commit 37d7226 into main Nov 15, 2024
9 of 10 checks passed
@meissadia meissadia deleted the 1050-inst-prof-language-pt2 branch November 15, 2024 18:18
@natalia-fitzgerald
Copy link

natalia-fitzgerald commented Nov 18, 2024

@meissadia

I am reviewing on DevPub and would like to make some additional changes.

Both View and Update pages

  • Inline alerts should be warning (Gold)
  • In introduction text, spell out "Global Legal Entity Identifier Foundation" in the intro and follow with the acronym (GLEIF) in parenthesis.
  • LEI message should be "renew" rather than "review"
Screenshot 2024-11-18 at 3 58 06 PM

View form

  • Change last sentence of intro for View your parent entity information (if applicable)
    If you wish to update the following data, contact your Local Operating Unit (LOU) or visit the Federal Reserve Board. If you have parent entities with no LEI or RSSD ID and wish to provide their names, submit a request to update your financial institution profile.
Screenshot 2024-11-18 at 5 52 56 PM
  • At mobile, there's a wrapping issue with an instance of RSSD ID.
Screenshot 2024-11-18 at 4 38 14 PM

Update form

  • Change last sentence of section intro for "Update your parent entity information (if applicable)" and spell out LOU (as shown below)
    To request an update to an LEI-based parent entity, contact your Local Operating Unit (LOU). To request an update to an RSSD ID-based parent entity, visit the Federal Reserve Board. If you have parent entities with no LEI or RSSD ID, provide their names below.
Screenshot 2024-11-18 at 5 52 48 PM

@natalia-fitzgerald
Copy link

natalia-fitzgerald commented Nov 19, 2024

@meissadia
I have 3 more content updates and hopefully we'll be good.

View

  • Text update
    If your financial institution has an RSSD ID, visit the Federal Reserve Board to update the following information. If your financial institution does not have an RSSD ID and you need to update this information, submit a request to update your financial institution profile.

Screenshot 2024-11-19 at 3 20 09 PM

  • Text update
    To update the following information, contact your Local Operating Unit (LOU) or visit the Federal Reserve Board. If you have parent entities with no LEI or RSSD ID and need to provide their names, submit a request to update your financial institution profile.

Screenshot 2024-11-19 at 3 20 15 PM

Update

  • Text update
    Select all applicable types of financial institutions from the list below. If none of the enumerated types appropriately describe your financial institution, or if you need to add additional types, select "Other" and add your entry to the text field.

Screenshot 2024-11-19 at 3 20 25 PM

meissadia added a commit that referenced this pull request Dec 6, 2024
… Warnings (#1066)

Closes #1053 

Sorry, this turned into a stir fry with lots of language updates mixed
in.

## Changes

- [Sign and Submit] Display missing LEI, TIN, or Type of FI as errors
- task: Address linting errors associated with empty Institution `data`
when API calls fail
- fix: Language updates which have been verified by Natalia
[here](#1052 (comment))
- fix: More language updates which have been verified by Natalia
[here](#1052 (comment))


## Screenshots

- [Sign and Submit] Display missing LEI, TIN, or Type of FI as errors
-
![screencapture-localhost-8899-filing-2024-123456789TESTBANK123-submit-2024-11-18-11_43_49](https://github.com/user-attachments/assets/0029dad6-7a5f-474c-83e6-6a7acdf60e10)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[View Institution Profile] Update LEI and TIN language
2 participants