-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Institution Profile pages - Update alert text for missing TIN and LEI #1052
Conversation
task: [Update institution info] Display TIN input first, RSSD ID second, Federal regulator third
@meissadia Here's a list of changes: Already discussed in our call:
Found in my review of the latest screenshots:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@meissadia
Looks good! I have reviewed the screenshots and they look good. All changes appear to be accounted for with the exception of the items that you have mentioned will be handled separately (Alert width
External link icons within an Alert).
@meissadia View
Update
|
… Warnings (#1066) Closes #1053 Sorry, this turned into a stir fry with lots of language updates mixed in. ## Changes - [Sign and Submit] Display missing LEI, TIN, or Type of FI as errors - task: Address linting errors associated with empty Institution `data` when API calls fail - fix: Language updates which have been verified by Natalia [here](#1052 (comment)) - fix: More language updates which have been verified by Natalia [here](#1052 (comment)) ## Screenshots - [Sign and Submit] Display missing LEI, TIN, or Type of FI as errors - ![screencapture-localhost-8899-filing-2024-123456789TESTBANK123-submit-2024-11-18-11_43_49](https://github.com/user-attachments/assets/0029dad6-7a5f-474c-83e6-6a7acdf60e10)
Closes #1050
Changes
How to test this PR
[ViewInstitutionProfile > index.tsx] Replace the
data
param highlighted in the screenshot below with the following.Visit the Institution profile page
Screenshots
View institution profile
Update institution profile