Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review design implementation of making most data fields default to "not applicable" #22

Closed
Tracked by #287
natalia-fitzgerald opened this issue Oct 30, 2024 · 9 comments
Assignees
Labels
content Write content for platform features or pages design review Review implementation of designs in development

Comments

@natalia-fitzgerald
Copy link
Collaborator

natalia-fitzgerald commented Oct 30, 2024

Review design implementation of "not applicable"-- cfpb/sbl-frontend#1013

  • Updated the fallback values for most fields to "Not applicable"
  • Ensured Type of Financial Institution, Federal Taxpayer Identification Number (TIN) show as blank values when missing
  • Updated language for Legal Entity Identifier Status from "Active/Inactive" to "Issued/Lapsed"
  • Refer to [Spike] Determine which fields are required to enable submission #2 for which unpopulated fields should be shown as blank
@natalia-fitzgerald
Copy link
Collaborator Author

natalia-fitzgerald commented Oct 30, 2024

@dan-padgett
After reviewing @meissadia's implementation, I am considering whether we may want to show some something for the two fields that are currently defaulting to blank when the user has not provided the information. This includes TIN and Type of financial institution.

What would you think of showing "Not provided" for fields where the user has not yet provided the required information.
Screenshot 2024-11-04 at 5 01 36 PM

@dan-padgett
Copy link
Collaborator

@natalia-fitzgerald I think we want the warning if we go this route. Otherwise there's a chance that "Not provided" is seen as an acceptable state. And given that, I wonder whether just having the alert would be better--maybe even going the route of a blank value with the warning below it. What do you think about those two options?

@natalia-fitzgerald
Copy link
Collaborator Author

Yeah, I actually considered that too but that also seemed to lack context.
Screenshot 2024-10-31 at 11 45 21 AM

@natalia-fitzgerald
Copy link
Collaborator Author

@meissadia @billhimmelsbach
We would like to implement this with "Not provided" instead of blank and the inline warning alert. The alert text is placeholder at this point but I will review with UX today.

Screenshot 2024-10-30 at 1 48 06 PM

@natalia-fitzgerald natalia-fitzgerald self-assigned this Oct 31, 2024
@natalia-fitzgerald
Copy link
Collaborator Author

natalia-fitzgerald commented Oct 31, 2024

@dan-padgett @angelcardoz

Warning alert content for your review:

LEI

  • Lapsed
  • Your financial institution must have an active LEI to file. Visit GLEIF for details on how to reactivate your LEI or email our support staff for assistance.

TIN

  • Not provided
  • You must provide a TIN for your financial institution to file. For instructions on how to provide this information visit update your financial institution profile.

Type of financial institution

  • Not provided
  • You must provide your type of financial institution to file. To provide this information visit update your financial institution profile.

@natalia-fitzgerald
Copy link
Collaborator Author

natalia-fitzgerald commented Oct 31, 2024

@dan-padgett @angelcardoz

LEI status

  • Lapsed
  • Your financial institution must have an active LEI to file. Visit GLEIF for instructions on how to reactivate your LEI or email our support staff for assistance.

Federal Taxpayer Identification Number (TIN)

  • Not provided
  • You must provide your TIN to file. Visit update your financial institution profile for instructions on how to update this information.

Type of financial institution

  • Not provided
  • You must provide your type of financial institution to file. Visit update your financial institution profile to provide this information.

Here's an updated mock-up based on our changes:
Screenshot 2024-10-31 at 5 03 57 PM

@natalia-fitzgerald natalia-fitzgerald added content Write content for platform features or pages design review Review implementation of designs in development mock-ups Design mock-ups for features or pages labels Oct 31, 2024
@natalia-fitzgerald
Copy link
Collaborator Author

natalia-fitzgerald commented Nov 7, 2024

@angelcardoz @dan-padgett
Updated based on where we landed on sign and submit.

Image

@natalia-fitzgerald natalia-fitzgerald removed the mock-ups Design mock-ups for features or pages label Nov 14, 2024
@natalia-fitzgerald
Copy link
Collaborator Author

Update:

@natalia-fitzgerald
Copy link
Collaborator Author

natalia-fitzgerald commented Nov 20, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content Write content for platform features or pages design review Review implementation of designs in development
Projects
None yet
Development

No branches or pull requests

2 participants