Skip to content

Commit

Permalink
Institution Profile pages - Update alert text for missing TIN and LEI (
Browse files Browse the repository at this point in the history
…#1052)

Closes #1050 

## Changes

- [View] Update alert texts for missing TIN and LEI
- [View] Update page intro text
- [View] Update LEI field label
- [Update] Ensure order: TIN, RSSD ID, Federal regulator
- [Update] Language updates

## How to test this PR


1. [ViewInstitutionProfile > index.tsx] Replace the `data` param
highlighted in the screenshot below with the following.

    ```
    const testBlankValues = {
      lei: 'FI_LEI',
      name: 'FI_INSTITUTION_NAME',
      hq_address_street_1: 'HQ_ADDRESS_STREET_1',
      hq_address_city: 'HQ_ADDRESS_CITY',
      hq_address_state: 'HQ_ADDRESS_STATE',
      hq_address_state_code: 'HQ_ADDRESS_STATE_CODE',
      hq_address_zip: 'HQ_ADDRESS_ZIP',
    };
    ```
<img width="846" alt="Screenshot 2024-10-22 at 2 03 45 PM"
src="https://github.com/user-attachments/assets/af4044c6-cc31-4799-870a-cc7fd5253315">

3. Visit the Institution profile page
    - ex. http://localhost:8899/institution/123456789TESTBANK123

## Screenshots

### View institution profile

![InstitutionProfile-view](https://github.com/user-attachments/assets/360fbc20-7717-4655-95b4-949751d0545f)

### Update institution profile

![InstitutionProfile-update](https://github.com/user-attachments/assets/5a3b05dd-63ae-43f7-ab25-b05978eacbc4)
  • Loading branch information
meissadia authored Nov 15, 2024
1 parent ca0e05e commit 37d7226
Show file tree
Hide file tree
Showing 5 changed files with 24 additions and 27 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -69,12 +69,19 @@ function UpdateIdentifyingInformation({
return (
<FormSectionWrapper>
<SectionIntro heading='Update your financial institution identifying information'>
If your financial institution has a Research, Statistics, Supervision,
Discount Identification (RSSD ID) number, provide it here and we will
pull your Federal Taxpayer Identification Number (TIN) and Federal
prudential regulator from NIC. If not, provide your TIN.
If your financial institution has an RSSD ID, provide it here and we
will pull your TIN and Federal prudential regulator from NIC. If not,
provide your TIN.
</SectionIntro>
<WellContainer className='u-mt30'>
<InputEntry
id={taxID}
label={InstitutionDataLabels.tin}
helperText={InstitutionHelperText.tin}
{...register(taxID)}
errorMessage={formErrors[taxID]?.message}
showError
/>
<InputEntry
id={rssdID}
label={InstitutionDataLabels.rssd}
Expand All @@ -86,22 +93,13 @@ function UpdateIdentifyingInformation({
errorMessage={formErrors[rssdID]?.message}
showError
/>
<InputEntry
id={taxID}
label={InstitutionDataLabels.tin}
helperText={InstitutionHelperText.tin}
{...register(taxID)}
errorMessage={formErrors[taxID]?.message}
showError
/>
<FieldFederalPrudentialRegulator {...{ register, data }} />
</WellContainer>
<SectionIntro className='mb-[1.875rem] mt-[2.8125rem]'>
Select all applicable types of financial institutions from the list
below. If the enumerated types do not appropriately describe your
institution, or if you wish to add additional types, select
&quot;Other&quot; and add your entry to the text field. Separate
multiple entries with a comma.
financial institution, or if you wish to add additional types, select
&quot;Other&quot; and add your entry to the text field.
</SectionIntro>
{/* @ts-expect-error Part of code cleanup for post-mvp see: https://github.com/cfpb/sbl-frontend/issues/717 */}
<FormMain>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -11,10 +11,10 @@ import { DisplayField, NOT_APPLICABLE } from './DisplayField';

const defaultDescription = (
<>
If you wish to update the following data, contact your LOU or visit the{' '}
<Links.FederalReserveBoard />. If you wish to provide only your parent
entity’s name, where no LEI or RSSD ID exists, submit a request to{' '}
<Links.UpdateInstitutionProfile />.
If you wish to update the following data, contact your Local Operating Unit
(LOU) or visit the <Links.FederalReserveBoard />. If you wish to provide
only your parent entity’s name, where no LEI or RSSD ID exists, submit a
request to <Links.UpdateInstitutionProfile />.
</>
);

Expand Down
11 changes: 5 additions & 6 deletions src/pages/Filing/ViewInstitutionProfile/DisplayField.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -24,17 +24,16 @@ function LinkUpdateInstitutionProfile(): JSX.Element {
const NotProvidedAlertMessage = {
[InstitutionDataLabels.leiStatus]: (
<p>
Your financial institution must have an active LEI to file. Visit{' '}
<CommonLinks.GLIEF isExternalLink={false} /> for instructions on how to
reactivate your LEI or{' '}
<CommonLinks.EmailSupportStaff subject='Reactivating an LEI' /> for
assistance.
Your LEI registration status must be &quot;Issued&quot; to file. If you
need to review your LEI registration, contact your Local Operating Unit
(LOU) or visit <CommonLinks.GLIEF isExternalLink={false} /> to identify
your LOU.
</p>
),
[InstitutionDataLabels.tin]: (
<p>
You must provide your TIN to file. Visit <LinkUpdateInstitutionProfile />{' '}
for instructions on how to update this information.
for instructions on how to provide this information.
</p>
),
[InstitutionDataLabels.fiType]: (
Expand Down
2 changes: 1 addition & 1 deletion src/pages/Filing/ViewInstitutionProfile/PageIntro.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ export function PageIntro(): JSX.Element {
return (
<TextIntroduction
heading='View your financial institution profile'
subheading='This profile reflects the most current data available to the CFPB for your financial institution. We pull data from sources including GLEIF (Global Legal Entity Identifier Foundation), the National Information Center (NIC), and direct requests to our support staff.'
subheading='This profile reflects the most current data available to the CFPB for your financial institution. We pull data from sources including Global Legal Entity Identifier Foundation (GLEIF), the National Information Center (NIC), and direct requests to our support staff.'
description={
<Paragraph>
Most updates to financial institution profile details must be handled
Expand Down
2 changes: 1 addition & 1 deletion src/pages/Filing/formHelpers.ts
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ const InstitutionDataLabels = {
fiType: 'Type of financial institution',
hqAddress: 'Headquarters address',
lei: 'Legal Entity Identifier (LEI)',
leiStatus: 'LEI status',
leiStatus: 'LEI registration status',
name: 'Name',
regName: 'Federal prudential regulator',
rssd: 'Research, Statistics, Supervision, Discount Identification (RSSD ID) number',
Expand Down

0 comments on commit 37d7226

Please sign in to comment.