Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tracker to fix todo in #394 CephFS snapshot/Clone PR #1242

Closed
6 tasks done
humblec opened this issue Jul 16, 2020 · 7 comments
Closed
6 tasks done

Tracker to fix todo in #394 CephFS snapshot/Clone PR #1242

humblec opened this issue Jul 16, 2020 · 7 comments
Labels
component/cephfs Issues related to CephFS
Milestone
release-3.2.0

Comments

@humblec
Copy link
Collaborator

humblec commented Jul 16, 2020 •
edited
Loading

This issue is for tracking the TODO which needs to be fixed after merging #394 , this will be closed after fixing all the todo's
for easier tracking am adding the TODO list here from the PR
@Madhu-1
Copy link
Collaborator

Madhu-1 commented Jul 16, 2020

@humblec Adding E2E for TODO doesn't seem correct. Without E2E in #394 how to ensure that everything works fine?

@humblec
Copy link
Collaborator Author

humblec commented Jul 16, 2020

@humblec Adding E2E for TODO doesn't seem correct. Without E2E in #394 how to ensure that everything works fine?

Sure, the rook cluster upgrade made me to put it here in first place, but removing it from the list as we need to sort this out any way. thanks ! 👍

@humblec humblec mentioned this issue Jul 17, 2020
Merged
7 tasks
@nixpanic nixpanic added the component/cephfs Issues related to CephFS label Jul 20, 2020
@humblec humblec added this to the release-3.1.0 milestone Aug 6, 2020
@Madhu-1
Copy link
Collaborator

Madhu-1 commented Aug 6, 2020 •
edited by humblec
Loading

  • Add test in upgrade e2e to create snapshot and clone from older PVC

This was referenced Aug 10, 2020
Merged
Merged
Closed
@humblec humblec mentioned this issue Aug 11, 2020
Merged
@Madhu-1
Copy link
Collaborator

Madhu-1 commented Aug 11, 2020

@humblec can you please add documentation for 400 snapshot limit in release notes

@Madhu-1
Copy link
Collaborator

Madhu-1 commented Aug 12, 2020

@humblec can you please add documentation for 400 snapshot limit in release notes

@humblec FYI this also needs to be updated in current cephfs snapshot doc

Madhu-1 added a commit to Madhu-1/ceph-csi that referenced this issue Aug 13, 2020
@Madhu-1
doc: add note for cephfs snapshot limitation
0dbbb9d 
added a note for cephfs snapshot limitations

closes ceph#1242

Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
@Madhu-1 Madhu-1 mentioned this issue Aug 13, 2020
Merged
@Madhu-1
Copy link
Collaborator

Madhu-1 commented Aug 13, 2020

Revalidate the error strings and CSI error returns. ( Deferred to 3.2.0)

as this is deferred to 3.2.0 moving this to next milestone

@Madhu-1 Madhu-1 modified the milestones: release-3.1.0, release-3.2.0 Aug 13, 2020
Madhu-1 added a commit to Madhu-1/ceph-csi that referenced this issue Aug 13, 2020
@Madhu-1
doc: add note for cephfs snapshot limitation
e35c96c 
added a note for cephfs snapshot limitations

closes ceph#1242

Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
@mergify mergify bot closed this as completed in f11486f Aug 13, 2020
@Madhu-1 Madhu-1 reopened this Aug 13, 2020
Madhu-1 added a commit to Madhu-1/ceph-csi that referenced this issue Aug 17, 2020
@Madhu-1
cephfs: use string const for cli error comparison
5b70154 
we should not return the GRPC CLI errors in errors
we need to return proper readable error messages
to the user for better understanding and better
debugging.

fixes ceph#1242

Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
Madhu-1 added a commit to Madhu-1/ceph-csi that referenced this issue Aug 17, 2020
@Madhu-1
cephfs: use string const for cli error comparison
e8cdc76 
we should not return the CLI errors in GRPC errors
we need to return proper readable error messages
to the user for better understanding and better
debugging.

fixes ceph#1242

Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
@Madhu-1 Madhu-1 mentioned this issue Aug 17, 2020
Merged
ceph-csi-bot pushed a commit to Madhu-1/ceph-csi that referenced this issue Aug 17, 2020
@Madhu-1
cephfs: use string const for cli error comparison
baa691c 
we should not return the CLI errors in GRPC errors
we need to return proper readable error messages
to the user for better understanding and better
debugging.

fixes ceph#1242

Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
Madhu-1 added a commit to Madhu-1/ceph-csi that referenced this issue Aug 18, 2020
@Madhu-1
cephfs: use string const for cli error comparison
4884df7 
we should not return the CLI errors in GRPC errors
we need to return proper readable error messages
to the user for better understanding and better
debugging.

fixes ceph#1242

Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
Madhu-1 added a commit to Madhu-1/ceph-csi that referenced this issue Aug 18, 2020
@Madhu-1
cephfs: use string const for cli error comparison
676d769 
we should not return the CLI errors in GRPC errors
we need to return proper readable error messages
to the user for better understanding and better
debugging.

updates ceph#1242

Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
ceph-csi-bot pushed a commit to Madhu-1/ceph-csi that referenced this issue Aug 19, 2020
@Madhu-1
cephfs: use string const for cli error comparison
d770cbc 
we should not return the CLI errors in GRPC errors
we need to return proper readable error messages
to the user for better understanding and better
debugging.

updates ceph#1242

Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
mergify bot pushed a commit that referenced this issue Aug 19, 2020
@Madhu-1 @mergify
cephfs: use string const for cli error comparison
0bd45a5 
we should not return the CLI errors in GRPC errors
we need to return proper readable error messages
to the user for better understanding and better
debugging.

updates #1242

Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
mergify bot pushed a commit that referenced this issue Aug 19, 2020
@Madhu-1
cephfs: use string const for cli error comparison
d6de84f 
we should not return the CLI errors in GRPC errors
we need to return proper readable error messages
to the user for better understanding and better
debugging.

updates #1242

Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
(cherry picked from commit 0bd45a5)
mergify bot pushed a commit that referenced this issue Aug 19, 2020
@Madhu-1 @mergify
cephfs: use string const for cli error comparison
a8e6bde 
we should not return the CLI errors in GRPC errors
we need to return proper readable error messages
to the user for better understanding and better
debugging.

updates #1242

Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
(cherry picked from commit 0bd45a5)
@humblec
Copy link
Collaborator Author

humblec commented Sep 29, 2020

Closing this one for now as these are already addressed.

@humblec humblec closed this as completed Sep 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component/cephfs Issues related to CephFS
Projects
None yet
Milestone
release-3.2.0
Development

No branches or pull requests
3 participants
@nixpanic @humblec @Madhu-1