cephfs: use string const for cli error comparison #1383
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Madhu-1
added
backport-to-release-v3.1
component/cephfs
Madhu-1
requested review from
humblec and
nixpanic
and removed request for
humblec
|
Thanks @Madhu-1 |
humblec
previously approved these changes
Aug 17, 2020
|
/retest all |
|
/test ci/centos/mini-e2e-helm/k8s-1.17.8 |
ceph-csi-bot
force-pushed
the
fix-cephfs-err
branch
from
e8cdc76 to
baa691c
Compare
nixpanic
previously approved these changes
Aug 17, 2020
|
/retest ci/centos/mini-e2e |
|
/retest ci/centos/mini-e2e-helm/k8s-1.17.8 |
|
/retest commitlint |
|
This pull request now has conflicts with the target branch. Could you please resolve conflicts and force push the corrected changes? 🙏 |
Madhu-1
force-pushed
the
fix-cephfs-err
branch
from
baa691c to
4884df7
Compare
mergify
bot
dismissed stale reviews from humblec and nixpanic
Pull request has been modified.
done. please note that the issue needs to be closed manually as it was the last pending item in issue list |
Madhu-1
force-pushed
the
fix-cephfs-err
branch
from
4884df7 to
676d769
Compare
nixpanic
approved these changes
Aug 19, 2020
Madhu-1
added
the
ready-to-merge
|
added ready-to-merge as @humblec already approved it |
we should not return the CLI errors in GRPC errors we need to return proper readable error messages to the user for better understanding and better debugging. updates ceph#1242 Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
ceph-csi-bot
force-pushed
the
fix-cephfs-err
branch
from
676d769 to
d770cbc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
we should not return the CLI errors in GRPC errors, we need to return proper readable error messages
to the user for better understanding and better debugging.
updates #1242
Signed-off-by: Madhu Rajanna madhupr007@gmail.com