e2e: add backend cephfs subvolume validation #1319
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nixpanic
added
component/cephfs
|
@Mergifyio rebase |
|
Command |
|
@Mergifyio rebase |
|
Command |
|
/retest ci/centos/mini-e2e/k8s-1.18.5 |
|
/retest ci/centos/containerized-tests |
|
@Madhu-1 sure.. Will review this soon. Also once the snap PR in, we could use this PR for adding that for snapshot backend too. |
|
This pull request now has conflicts with the target branch. Could you please resolve conflicts and force push the corrected changes? 🙏 |
humblec
previously approved these changes
Aug 10, 2020
|
looks like PVC-PVC clone backend subvolumes are not getting deleted. from https://jenkins-ceph-csi.apps.ocp.ci.centos.org/job/mini-e2e-helm_k8s-1.18.5/93/consoleFull from https://jenkins-ceph-csi.apps.ocp.ci.centos.org/job/mini-e2e_k8s-1.17.8/112/consoleFull |
some check is e2e was missing added it |
|
/retest ci/centos/mini-e2e/k8s-1.17.8 |
|
@Madhu-1 can you please revisit this PR ? |
|
@Mergifyio rebase |
added a helper function in e2e to list subvolumes in a filesystem Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
added a backend validation to check subvolumes count when we create and delete pvc. fixes ceph#1316 Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
added backend subvolume validation for cephfs snapshot restore and pvc to pvc clone. Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
|
Command
|
humblec
approved these changes
Aug 11, 2020
ShyamsundarR
approved these changes
Aug 11, 2020
nixpanic
approved these changes
Aug 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added a backend validation to check subvolumes count when we create and delete PVC.
fixes #1316
updates: #1242
Signed-off-by: Madhu Rajanna madhupr007@gmail.com