This repository has been archived by the owner on Dec 13, 2022. It is now read-only.
fix(mon): bugs in event/system logs #6383
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remove old smarty lib and add new one to composer requirements. Update smarty plugin folder to be outside composer module. Resolves #CP7M-9
replace deprecated Archive_Zip with ZipArchive class from PHP ZIP module and add composer dependency for Archive_Tar Resolves #CP7M-13
replace pear package Archive_Tar with PharData class Resolves #CP7M-13
fix non numeric additions part of: cp7m10
Fixing various errors (not only smarty related) in validated views Resolves CP7M-10
* fix(base): fix some warnings and deprecations notes fix double start a session some PHP files, fix using of undefinded variables, fix calling of non-static method as static, fix using of old PEAR DB const DB_FETCHMODE_ASSOC, remove manual loading of Smarty lib from custom views section fix advmultiselect warnings and deprecates notes because the library is officially deprecated fix admin ACL UI -> fix calling of undefined index and calling of non-static method as static Resolves CP7M-15
Update db call, fix post-merge missing db execution call on images Resolves: CP7M10
Update free to closeCursor
* fix(global): remove warnings and undefined variables * refactor(core): rework post-upgrade errors Refactor code not compliant with php7.2 Regarding: CP7M-7 * fix(global): remove small warnings and errors * refactor(core): call non-static method in widgets as host-monitoring calls methods CentreonUtils::conditionBuilder and CentreonUtils::operandToMysqlFormat as static but they are non-static Resolves CP7M-7 * fix(global): remove small warnings and errors * refactor(core): fix warnings from tests fix issues as "Only variables should be assigned by reference", "Undefined index", "Methods with the same name as their class will not be constructors in a future version of PHP" and etc. Resolves CP7M-7
Fix incorrectly pushed variable name
* refactor(install): fix upgrade process change MySQL library of php requirements and add a check for release notes file Resolves CP7M-24 * refactor(install): add missing folder and cfg mock add missing folder `www/install/tmp` and add mock of `www/install/install.conf.php` Resolves CP7M-24 * refactor(install): Fix smarty and smarty-plugins loading Resolves problem for unknown smarty plugin. Loads composer-managed smarty.
* fix(global): remove warnings and undefined variables * refactor(core): rework post-upgrade errors Refactor code not compliant with php7.2 Regarding: CP7M-7 * fix(global): remove small warnings and errors * refactor(core): call non-static method in widgets as host-monitoring calls methods CentreonUtils::conditionBuilder and CentreonUtils::operandToMysqlFormat as static but they are non-static Resolves CP7M-7 * fix(global): remove small warnings and errors * refactor(core): fix warnings from tests fix issues as "Only variables should be assigned by reference", "Undefined index", "Methods with the same name as their class will not be constructors in a future version of PHP" and etc. Resolves CP7M-7 * fix(global): use quickform and smarty from composer * fix(global): PHP warnings, notifications and mergeWithInitialValues to return correct result fix CentreonUtils::mergeWithInitialValues to return result from submitted data fix PHP warinings and notifications from Host template UI fix CentreonHosttemplates::getObjectForSelect2 attributes to be the same as the parent method Resolves CP7M-7 * refactor(base) Fix errors found after running acceptance tests Fix various problems caused by Smarty and Quickform, detected by acceptance tests. Regarding CP7M7 * fix(config): fix variable name (#6276) Fix incorrectly pushed variable name
reset pagination page on new filter posted Resolves: CP7M-59
disable all PHP errors in CLAPI (bin/centreon, api/index.php, api/internal.php) add interface and trait instead checking for method add missing arguments in Factory constructor remove loading of centreon.conf.php when bootstrap.php is in use add moduleId in centreon_administration_module when use methods for upgrading and removing a module fix undefined variable in centreonDependency.class.php fix undefined offset in centreonHostGroup.class.php use sendResult instead sendJson in class CentreonWebService add default status if missing in traps list Resolves CP7M-64
* fix(knowledgebase): fix compatibility with MW1.30 Apply new API rules and add compatibility downwards to 1.27 Resolves: CP7M-63 * refactor(knowledgebase): remove cookies after curl call
Centreon Poller Display will not be compatible with PHP 7 and therefore cannot be successfully build against Centreon Web 2.9.
* fix(widget): remove unused variable code cleaning Resolve CP7M-53 * fix(engine): remove getting a reference from the function code cleaning Resolve CP7M-53 * fix(ldap): Illegal string offset 'action' the issue happens when try to import LDAP users without a selected checkbox Resolve CP7M-53
* fix(install): module without cfg throw warnings * chore(base): ignore content of www/img/media folder Resolve CP7M-53
* fix(export): Filter type work with CG * fix(export): Select specific HC resource filters now * fix(clapi): apply filters on service category export * refacto(clapi): refacto export of centreon clapi * fix(clapi) dependency injector * fix(clapi) compatibility parent/child * fix(clapi) order export * fix(clapi) clean unused local variable
* fix(knowledgebase): fix compatibility with MW1.30 Apply new API rules and add compatibility downwards to 1.27 Resolves: CP7M-63 * refactor(knowledgebase): remove cookies after curl call * fix(auth): Disallow login with saved details of ldap user Disconnect user if disabled/not found in ldap server instead of fall back to local auth Closes: CP7M-76 * fix(ldap): Update ldap groups sync Update logic to sync ldap groups. Force ldap resync upon login. * refactor(contactgroups): change fetchRow to fetch
Resolve CP7M-106 Ref #6216
Resolve CP7M-105 Ref #6359
JS bugs issue related with selector for limit of rows improve code readability Resolve CP7M-104 Ref #6367
vhr
requested review from
julienmathis,
loiclau,
v-radev,
kduret,
victorvassilev and
sc979
kduret
force-pushed
the
php7-migration
branch
5 times, most recently
from
fdbb834 to
a17394d
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JS bugs
issue related with selector for limit of rows
improve code readability
Resolve CP7M-104
Ref #6367