This repository has been archived by the owner on Dec 13, 2022. It is now read-only.
Cp7 m 69 fix ldap groups #6370
Merged
Cp7 m 69 fix ldap groups #6370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
June 8, 2018 13:17
Apply new API rules and add compatibility downwards to 1.27 Resolves: CP7M-63
Disconnect user if disabled/not found in ldap server instead of fall back to local auth Closes: CP7M-76
Update logic to sync ldap groups. Force ldap resync upon login.
sc979
suggested changes
Jun 15, 2018
| $res = $this->db->query("SELECT cg_id, cg_name, cg_ldap_dn FROM contactgroup | ||
| WHERE cg_type = 'ldap' AND ar_id = " . $ldaprow['ar_id']); | ||
|
|
||
|
|
||
| while ($row = $res->fetchRow()) { |
There was a problem hiding this comment.
please use fetch() instead of fetchRow() occurrences, when working on a php7 project // 2.9.
fetchRow() is surcharged with fetch() in centreon/class/centreonPdoStatement
There was a problem hiding this comment.
thanks for the reminder, pushing that fix in a moment :)
sc979
approved these changes
Jun 15, 2018
vhr
approved these changes
Jun 15, 2018
v-radev
approved these changes
Jun 15, 2018
kduret
pushed a commit
that referenced
this pull request
Jun 20, 2018
* fix(knowledgebase): fix compatibility with MW1.30 Apply new API rules and add compatibility downwards to 1.27 Resolves: CP7M-63 * refactor(knowledgebase): remove cookies after curl call * fix(auth): Disallow login with saved details of ldap user Disconnect user if disabled/not found in ldap server instead of fall back to local auth Closes: CP7M-76 * fix(ldap): Update ldap groups sync Update logic to sync ldap groups. Force ldap resync upon login. * refactor(contactgroups): change fetchRow to fetch
kduret
pushed a commit
that referenced
this pull request
Jun 20, 2018
* fix(knowledgebase): fix compatibility with MW1.30 Apply new API rules and add compatibility downwards to 1.27 Resolves: CP7M-63 * refactor(knowledgebase): remove cookies after curl call * fix(auth): Disallow login with saved details of ldap user Disconnect user if disabled/not found in ldap server instead of fall back to local auth Closes: CP7M-76 * fix(ldap): Update ldap groups sync Update logic to sync ldap groups. Force ldap resync upon login. * refactor(contactgroups): change fetchRow to fetch
kduret
pushed a commit
that referenced
this pull request
Jun 20, 2018
* fix(knowledgebase): fix compatibility with MW1.30 Apply new API rules and add compatibility downwards to 1.27 Resolves: CP7M-63 * refactor(knowledgebase): remove cookies after curl call * fix(auth): Disallow login with saved details of ldap user Disconnect user if disabled/not found in ldap server instead of fall back to local auth Closes: CP7M-76 * fix(ldap): Update ldap groups sync Update logic to sync ldap groups. Force ldap resync upon login. * refactor(contactgroups): change fetchRow to fetch
kduret
pushed a commit
that referenced
this pull request
Jun 20, 2018
* fix(knowledgebase): fix compatibility with MW1.30 Apply new API rules and add compatibility downwards to 1.27 Resolves: CP7M-63 * refactor(knowledgebase): remove cookies after curl call * fix(auth): Disallow login with saved details of ldap user Disconnect user if disabled/not found in ldap server instead of fall back to local auth Closes: CP7M-76 * fix(ldap): Update ldap groups sync Update logic to sync ldap groups. Force ldap resync upon login. * refactor(contactgroups): change fetchRow to fetch
kduret
pushed a commit
that referenced
this pull request
Jun 20, 2018
* fix(knowledgebase): fix compatibility with MW1.30 Apply new API rules and add compatibility downwards to 1.27 Resolves: CP7M-63 * refactor(knowledgebase): remove cookies after curl call * fix(auth): Disallow login with saved details of ldap user Disconnect user if disabled/not found in ldap server instead of fall back to local auth Closes: CP7M-76 * fix(ldap): Update ldap groups sync Update logic to sync ldap groups. Force ldap resync upon login. * refactor(contactgroups): change fetchRow to fetch
kduret
pushed a commit
that referenced
this pull request
Jun 20, 2018
* fix(knowledgebase): fix compatibility with MW1.30 Apply new API rules and add compatibility downwards to 1.27 Resolves: CP7M-63 * refactor(knowledgebase): remove cookies after curl call * fix(auth): Disallow login with saved details of ldap user Disconnect user if disabled/not found in ldap server instead of fall back to local auth Closes: CP7M-76 * fix(ldap): Update ldap groups sync Update logic to sync ldap groups. Force ldap resync upon login. * refactor(contactgroups): change fetchRow to fetch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.