This repository has been archived by the owner on Dec 13, 2022. It is now read-only.
fix(knowledgebase): fix compatibility with MW1.30 #6361
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Apply new API rules and add compatibility downwards to 1.27 Resolves: CP7M-63
victorvassilev
requested review from
loiclau,
kduret,
sc979,
vhr,
leoncx and
v-radev
v-radev
approved these changes
Jun 8, 2018
vhr
approved these changes
Jun 8, 2018
sc979
suggested changes
Jun 8, 2018
| curl_setopt($curl, CURLOPT_URL, $this->url); | ||
| curl_setopt($curl, CURLOPT_RETURNTRANSFER, true); | ||
| curl_setopt($curl, CURLOPT_POST, true); | ||
| curl_setopt($curl, CURLOPT_COOKIEFILE, $cookiefile); |
There was a problem hiding this comment.
can you add an expiration time using for example CURLOPT_CONNECTTIMEOUT
There was a problem hiding this comment.
added removal of cookies as agreed
sc979
approved these changes
Jun 8, 2018
kduret
pushed a commit
that referenced
this pull request
Jun 20, 2018
* fix(knowledgebase): fix compatibility with MW1.30 Apply new API rules and add compatibility downwards to 1.27 Resolves: CP7M-63 * refactor(knowledgebase): remove cookies after curl call
kduret
pushed a commit
that referenced
this pull request
Jun 20, 2018
* fix(knowledgebase): fix compatibility with MW1.30 Apply new API rules and add compatibility downwards to 1.27 Resolves: CP7M-63 * refactor(knowledgebase): remove cookies after curl call
kduret
pushed a commit
that referenced
this pull request
Jun 20, 2018
* fix(knowledgebase): fix compatibility with MW1.30 Apply new API rules and add compatibility downwards to 1.27 Resolves: CP7M-63 * refactor(knowledgebase): remove cookies after curl call
kduret
pushed a commit
that referenced
this pull request
Jun 20, 2018
* fix(knowledgebase): fix compatibility with MW1.30 Apply new API rules and add compatibility downwards to 1.27 Resolves: CP7M-63 * refactor(knowledgebase): remove cookies after curl call
kduret
pushed a commit
that referenced
this pull request
Jun 20, 2018
* fix(knowledgebase): fix compatibility with MW1.30 Apply new API rules and add compatibility downwards to 1.27 Resolves: CP7M-63 * refactor(knowledgebase): remove cookies after curl call
kduret
pushed a commit
that referenced
this pull request
Jun 20, 2018
* fix(knowledgebase): fix compatibility with MW1.30 Apply new API rules and add compatibility downwards to 1.27 Resolves: CP7M-63 * refactor(knowledgebase): remove cookies after curl call
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apply new API rules and add compatibility downwards to 1.27
Resolves: CP7M-63