Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: enable querying state through grpc (backport #3423) #3424

Merged
merged 1 commit into from
May 2, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented May 2, 2024

Closes: #3422

We seemed to have forgotten to add the query function which means ABCIQuery wasn't working even although the grpc endpoint was exposed

also related to: #3421


This is an automatic backport of pull request #3423 done by Mergify.

Closes: #3422

We seemed to have forgotten to add the query function which means
`ABCIQuery` wasn't working even although the grpc endpoint was exposed

also related to: #3421

Co-authored-by: Ismail Khoffi <Ismail.Khoffi@gmail.com>
(cherry picked from commit 99bbedf)
@mergify mergify bot requested a review from a team as a code owner May 2, 2024 14:09
@mergify mergify bot requested review from rootulp and cmwaters May 2, 2024 14:09
Copy link
Contributor

coderabbitai bot commented May 2, 2024

Important

Auto Review Skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions github-actions bot added the bot item was created by a bot label May 2, 2024
@cmwaters cmwaters merged commit ebd1be5 into v1.x May 2, 2024
24 of 25 checks passed
@cmwaters cmwaters deleted the mergify/bp/v1.x/pr-3423 branch May 2, 2024 14:18
renaynay added a commit to celestiaorg/celestia-node that referenced this pull request May 9, 2024
This PR bumps app to v1.9.0, which notably includes
celestiaorg/celestia-app#3424

complete release notes can be found
https://github.com/celestiaorg/celestia-app/releases/tag/v1.9.0

Co-authored-by: rene <41963722+renaynay@users.noreply.github.com>
renaynay added a commit to celestiaorg/celestia-node that referenced this pull request May 9, 2024
…for state reads (#3359)

Resolves #3357 

Blocked on patch release from app including
celestiaorg/celestia-app#3424

Corresponding docs PR celestiaorg/docs#1558
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot item was created by a bot
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants