Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide ABCI query over gRPC #3422

Closed
renaynay opened this issue May 2, 2024 · 0 comments · Fixed by #3423
Closed

Provide ABCI query over gRPC #3422

renaynay opened this issue May 2, 2024 · 0 comments · Fixed by #3423

Comments

@renaynay
Copy link
Member

renaynay commented May 2, 2024

We need to use tmservice.ServiceClient as per celestiaorg/celestia-node#3357

However nil is passed to RegisterTendermintService.
@renaynay renaynay mentioned this issue May 2, 2024
Closed
2 tasks
@cmwaters cmwaters mentioned this issue May 2, 2024
Merged
@liamsi liamsi mentioned this issue May 2, 2024
Open
2 tasks
cmwaters added a commit that referenced this issue May 2, 2024
@cmwaters @liamsi
feat: enable querying state through grpc (#3423)
99bbedf 
Closes: #3422

We seemed to have forgotten to add the query function which means
`ABCIQuery` wasn't working even although the grpc endpoint was exposed

also related to: #3421

Co-authored-by: Ismail Khoffi <Ismail.Khoffi@gmail.com>
mergify bot pushed a commit that referenced this issue May 2, 2024
@cmwaters @mergify
feat: enable querying state through grpc (#3423)
0619f75 
Closes: #3422

We seemed to have forgotten to add the query function which means
`ABCIQuery` wasn't working even although the grpc endpoint was exposed

also related to: #3421

Co-authored-by: Ismail Khoffi <Ismail.Khoffi@gmail.com>
(cherry picked from commit 99bbedf)
@mergify mergify bot mentioned this issue May 2, 2024
Merged
cmwaters added a commit that referenced this issue May 2, 2024
@mergify @cmwaters
feat: enable querying state through grpc (backport #3423) (#3424)
ebd1be5 
Closes: #3422

We seemed to have forgotten to add the query function which means
`ABCIQuery` wasn't working even although the grpc endpoint was exposed

also related to: #3421<hr>This is an automatic backport of pull request
#3423 done by [Mergify](https://mergify.com).

Co-authored-by: Callum Waters <cmwaters19@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: enable querying state through grpc celestiaorg/celestia-app
1 participant
@renaynay