Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(state): Remove need for core RPC conn and rely only on gRPC for state reads #3359

Merged
merged 8 commits into from
May 9, 2024

Conversation

renaynay
Copy link
Member

@renaynay renaynay commented May 2, 2024

Resolves #3357

Blocked on patch release from app including celestiaorg/celestia-app#3424

Corresponding docs PR celestiaorg/docs#1558

@renaynay renaynay added the area:state Related to fetching state and state execution label May 2, 2024
@renaynay renaynay self-assigned this May 2, 2024
@renaynay renaynay added the kind:refactor Attached to refactoring PRs label May 2, 2024
@renaynay renaynay changed the title chore(state): Remove need for core RPC conn and rely only on gRPC for state reads refactor(state): Remove need for core RPC conn and rely only on gRPC for state reads May 2, 2024
state/core_access.go Outdated Show resolved Hide resolved
@renaynay renaynay marked this pull request as ready for review May 6, 2024 17:00
state/core_access.go Outdated Show resolved Hide resolved
state/core_access.go Outdated Show resolved Hide resolved
state/core_access.go Outdated Show resolved Hide resolved
state/core_access.go Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented May 6, 2024

Codecov Report

Attention: Patch coverage is 73.68421% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 44.56%. Comparing base (2469e7a) to head (cfa8fa4).
Report is 54 commits behind head on main.

Files Patch % Lines
state/core_access.go 77.77% 2 Missing and 2 partials ⚠️
nodebuilder/state/core.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3359      +/-   ##
==========================================
- Coverage   44.83%   44.56%   -0.28%     
==========================================
  Files         265      272       +7     
  Lines       14620    15244     +624     
==========================================
+ Hits         6555     6793     +238     
- Misses       7313     7666     +353     
- Partials      752      785      +33     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Wondertan
Wondertan previously approved these changes May 6, 2024
state/core_access.go Outdated Show resolved Hide resolved
@liamsi
Copy link
Member

liamsi commented May 7, 2024

Is it in scope of this Pr to ensure TLS encryption works for gRPC? And for bridge nodes TLS for RPC to core? If not I assume this will be tackled shortly after?

@Wondertan
Copy link
Member

Is it in scope of this Pr to ensure TLS encryption works for gRPC? And for bridge nodes TLS for RPC to core? If not I assume this will be tackled shortly after?

It's good to have if for privacy reasons so that no MITM can see the addresses and balances you request. Worth having an issue

Copy link
Member

@Wondertan Wondertan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM otherwise

@liamsi
Copy link
Member

liamsi commented May 7, 2024

It's good to have if for privacy reasons so that no MITM can see the addresses and balances you request. Worth having an issue

There was an over 10 months old issue and it was closed... Rene opened a new one #3377

state/core_access.go Show resolved Hide resolved
@Wondertan
Copy link
Member

Wondertan commented May 7, 2024

#2439 (comment)

🤔

I guess Ramin misunderstood the relation of that issue because one does not replace the other one.

@ramin
Copy link
Contributor

ramin commented May 7, 2024

#2439 (comment)

"Make secured connection possible"

@renaynay renaynay merged commit 7f5cf06 into celestiaorg:main May 9, 2024
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:state Related to fetching state and state execution kind:refactor Attached to refactoring PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

improvement(state | nodebuilder/state): Use ABCIQuery over gRPC
6 participants