Add TypeScript types to the xTile family of components #13536 #13631
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kubijo
changed the title
kubijo
commented
Apr 20, 2023
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
kubijo
force-pushed
the
types/ExpandableTile
branch
2 times, most recently
from
69b7d42 to
02baaab
Compare
✅ Deploy Preview for carbon-components-react ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
francinelucca
requested changes
Apr 26, 2023
There was a problem hiding this comment.
Mostly LGTM, I'm doing some research on the name & value props to confirm we're good to remove but in the meantime, looks like some CI checks are failing and also I think we should add the light prop to the components' interface. See https://github.com/carbon-design-system/carbon/blob/main/packages/react/src/components/ComboBox/ComboBox.tsx#L170
TIA!
francinelucca
requested changes
Apr 27, 2023
kubijo
force-pushed
the
types/ExpandableTile
branch
from
482fd81 to
8842ea6
Compare
|
@kubijo thanks for your work so far on this one. There's some remaining feedback to address here I think and status checks are failing. |
kubijo
force-pushed
the
types/ExpandableTile
branch
from
8842ea6 to
184ff1c
Compare
There was a problem hiding this comment.
This is most of the way there, looks like there's one outstanding comment @kubijo #13631 (comment). Other than that LGTM
kubijo
force-pushed
the
types/ExpandableTile
branch
2 times, most recently
from
1ec242e to
2af4627
Compare
francinelucca
requested changes
Jun 12, 2023
kubijo
force-pushed
the
types/ExpandableTile
branch
from
2af4627 to
2f5e54a
Compare
francinelucca
added
status: one more review 👀
and removed
status: ready for review 👀
labels
tay1orjones
approved these changes
Jun 15, 2023
tay1orjones
added
status: ready to merge 🎉
and removed
status: one more review 👀
labels
This was referenced Oct 30, 2023
wkeese
added a commit
to wkeese/carbon
that referenced
this pull request
Nov 18, 2024
Refs carbon-design-system#13537, carbon-design-system#13631. Update PropTypes so "name" and "value" are reported as deprecated. (The description already included @deprecated, but that's different.) More importantly, stop marking "value" as required. Properties cannot be deprecated and required at the same time.
wkeese
added a commit
to wkeese/carbon
that referenced
this pull request
Nov 18, 2024
Refs carbon-design-system#13537, carbon-design-system#13631. Update PropTypes so "name" and "value" are reported as deprecated. (The description already included @deprecated, but that's different.) More importantly, stop marking "value" as required. Properties cannot be deprecated and required at the same time.
wkeese
added a commit
to wkeese/carbon
that referenced
this pull request
Nov 19, 2024
github-merge-queue bot
pushed a commit
that referenced
this pull request
Nov 19, 2024
* fix(selectable-tile): don't require deprecated property "value" Refs #13537, #13631. Update PropTypes so "name" and "value" are reported as deprecated. (The description already included @deprecated, but that's different.) More importantly, stop marking "value" as required. Properties cannot be deprecated and required at the same time. * fix(selectable-tile): remove deprecated properties from test Refs #13537, #13631.
wkeese
added a commit
to wkeese/carbon
that referenced
this pull request
Nov 22, 2024
I previously fixed PropTypes but forgot to update the Typescript declaration. Fixes carbon-design-system#16977. Refs carbon-design-system#13537, carbon-design-system#13631.
wkeese
added a commit
to wkeese/carbon
that referenced
this pull request
Nov 22, 2024
I previously fixed PropTypes but forgot to update the Typescript declaration. Fixes carbon-design-system#16977. Refs carbon-design-system#13537, carbon-design-system#13631.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #13542, #13536, #13537
Changelog
New
Tile,SelectableTile,ExpandableTile,TileAboveTheFoldContent,TileBelowTheFoldContent