Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: SelectableTile: deprecated value prop #16977

Closed
2 tasks done
shocquu opened this issue Jul 17, 2024 · 2 comments · Fixed by #18096 or #18143
Closed
2 tasks done

[Bug]: SelectableTile: deprecated value prop #16977

shocquu opened this issue Jul 17, 2024 · 2 comments · Fixed by #18096 or #18143
Labels
component: tile good first issue 👋 Used by GitHub to elevate contribution opportunities role: dev 🤖 severity: 4 https://ibm.biz/carbon-severity type: bug 🐛

Comments

@shocquu
Copy link

shocquu commented Jul 17, 2024

Package

@carbon/react

Browser

No response

Package version

1.61.0

React version

18.0.0

Description

The value prop is marked as deprecated despite being required.

Reproduction/example

https://stackblitz.com/edit/vitejs-vite-dbavtk?file=src%2FApp.tsx

Steps to reproduce

  1. Use the SelectableTile component with TypeScript,
  2. Add value prop
  3. Have it marked as deprecated

Suggested Severity

Severity 4 = Unrelated to a user task, has a workaround or does not need a workaround.

Application/PAL

No response

Code of Conduct
@Gururajj77 Gururajj77 moved this to ⏱ Backlog in Design System Jul 18, 2024
@Gururajj77 Gururajj77 added the good first issue 👋 Used by GitHub to elevate contribution opportunities label Jul 18, 2024
This was referenced Jul 19, 2024
Closed
Closed
@niveamartins
Copy link

Hey, guys! Can I have a look on this issue?

@wkeese wkeese mentioned this issue Nov 22, 2024
Merged
@wkeese
Copy link
Contributor

wkeese commented Nov 22, 2024

I didn't know about this ticket but I fixed this in #18096. Please close this.

wkeese added a commit to wkeese/carbon that referenced this issue Nov 22, 2024
@wkeese
fix(selectable-tile): make deprecated value property optional
f37d064 
I previously fixed PropTypes but forgot to update the Typescript declaration.

Fixes carbon-design-system#16977.
Refs carbon-design-system#13537, carbon-design-system#13631.
wkeese added a commit to wkeese/carbon that referenced this issue Nov 22, 2024
@wkeese
fix(selectable-tile): make deprecated value property optional
6cfd7d7 
I previously fixed PropTypes but forgot to update the Typescript declaration.

Fixes carbon-design-system#16977.
Refs carbon-design-system#13537, carbon-design-system#13631.
@wkeese wkeese mentioned this issue Nov 22, 2024
Merged
@shocquu shocquu closed this as completed Nov 22, 2024
@github-project-automation github-project-automation bot moved this from ⏱ Backlog to ✅ Done in Design System Nov 22, 2024
github-merge-queue bot pushed a commit that referenced this issue Dec 3, 2024
@wkeese
fix(selectable-tile): make deprecated value property optional (#18143)
05b6a4e 
I previously fixed PropTypes but forgot to update the Typescript declaration.

Fixes #16977.
Refs #13537, #13631.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component: tile good first issue 👋 Used by GitHub to elevate contribution opportunities role: dev 🤖 severity: 4 https://ibm.biz/carbon-severity type: bug 🐛
Projects
Design System
Status: ✅ Done
Milestone
No milestone
4 participants
@wkeese @niveamartins @shocquu @Gururajj77