Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add TypeScript types to SelectableTile #13537

Closed
Tracked by #12513
tay1orjones opened this issue Apr 17, 2023 · 2 comments
Closed
Tracked by #12513

Add TypeScript types to SelectableTile #13537

tay1orjones opened this issue Apr 17, 2023 · 2 comments
Labels
afrohacks See https://ibm.biz/afrohacks-hackathon area: typescript hacktoberfest See https://hacktoberfest.com/ needs: community contribution Due to roadmap and resource availability, we are looking for outside contributions on this issue. role: dev 🤖 status: help wanted 👐

Comments

@tay1orjones
Copy link
Member

No description provided.

@tay1orjones tay1orjones mentioned this issue Apr 17, 2023
Closed
@tay1orjones tay1orjones added status: help wanted 👐 role: dev 🤖 hacktoberfest See https://hacktoberfest.com/ area: typescript needs: community contribution Due to roadmap and resource availability, we are looking for outside contributions on this issue. labels Apr 17, 2023
@kubijo
Copy link
Contributor

kubijo commented Apr 19, 2023

I'm taking this

@kubijo kubijo mentioned this issue Apr 20, 2023
Merged
@tay1orjones tay1orjones added the afrohacks See https://ibm.biz/afrohacks-hackathon label Oct 30, 2023
@Tresau
Copy link
Contributor

Tresau commented Oct 30, 2023

@tay1orjones looks like this was not closed automatically from the PR #13631

wkeese added a commit to wkeese/carbon that referenced this issue Nov 18, 2024
@wkeese
fix(selectable-tile): don't require deprecated property "value"
24f3f03 
Refs carbon-design-system#13537, carbon-design-system#13631.

Update PropTypes so "name" and "value" are reported as deprecated.
(The description already included @deprecated, but that's different.)

More importantly, stop marking "value" as required.
Properties cannot be deprecated and required at the same time.
@wkeese wkeese mentioned this issue Nov 18, 2024
Merged
wkeese added a commit to wkeese/carbon that referenced this issue Nov 18, 2024
@wkeese
fix(selectable-tile): don't require deprecated property "value"
c8e1309 
Refs carbon-design-system#13537, carbon-design-system#13631.

Update PropTypes so "name" and "value" are reported as deprecated.
(The description already included @deprecated, but that's different.)

More importantly, stop marking "value" as required.
Properties cannot be deprecated and required at the same time.
wkeese added a commit to wkeese/carbon that referenced this issue Nov 19, 2024
@wkeese
fix(selectable-tile): remove deprecated properties from test
62b3bbd 
Refs carbon-design-system#13537, carbon-design-system#13631.
github-merge-queue bot pushed a commit that referenced this issue Nov 19, 2024
@wkeese
fix(selectable-tile): don't require deprecated property "value" (#18096)
28bf266 
* fix(selectable-tile): don't require deprecated property "value"

Refs #13537, #13631.

Update PropTypes so "name" and "value" are reported as deprecated.
(The description already included @deprecated, but that's different.)

More importantly, stop marking "value" as required.
Properties cannot be deprecated and required at the same time.

* fix(selectable-tile): remove deprecated properties from test

Refs #13537, #13631.
wkeese added a commit to wkeese/carbon that referenced this issue Nov 22, 2024
@wkeese
fix(selectable-tile): make deprecated value property optional
f37d064 
I previously fixed PropTypes but forgot to update the Typescript declaration.

Fixes carbon-design-system#16977.
Refs carbon-design-system#13537, carbon-design-system#13631.
wkeese added a commit to wkeese/carbon that referenced this issue Nov 22, 2024
@wkeese
fix(selectable-tile): make deprecated value property optional
6cfd7d7 
I previously fixed PropTypes but forgot to update the Typescript declaration.

Fixes carbon-design-system#16977.
Refs carbon-design-system#13537, carbon-design-system#13631.
github-merge-queue bot pushed a commit that referenced this issue Dec 3, 2024
@wkeese
fix(selectable-tile): make deprecated value property optional (#18143)
05b6a4e 
I previously fixed PropTypes but forgot to update the Typescript declaration.

Fixes #16977.
Refs #13537, #13631.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
afrohacks See https://ibm.biz/afrohacks-hackathon area: typescript hacktoberfest See https://hacktoberfest.com/ needs: community contribution Due to roadmap and resource availability, we are looking for outside contributions on this issue. role: dev 🤖 status: help wanted 👐
Projects
Initial TypeScript Support
Status: Done
Milestone
No milestone
Development

No branches or pull requests
3 participants
@tay1orjones @kubijo @Tresau