fix(authentication): sign-in with oauth provider failed #538
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix swapped "link" and "signIn" methods for oauth
robingenz
requested changes
Jan 6, 2024
robingenz
added
bug/fix
robingenz
changed the title
|
Changeset created! |
robingenz
requested changes
Jan 10, 2024
robingenz
approved these changes
Jan 10, 2024
|
@arstrasser Thank you for your contribution! |
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Very simple change to fix swapped link and signIn functions for oauth flow sign in.
Close #524
Issue:
Microsoft (and presumably other OAuth based sign in methods) were failing on iOS with a "No user signed in" error.
Swapping these functions as their names intend resolves the issue.
Pull request checklist
Please check if your PR fulfills the following requirements:
npm run changeset).