Skip to content

Commit

Permalink
fix(authentication): sign-in with oauth provider failed (#538)
Browse files Browse the repository at this point in the history
* Update OAuthProviderHandler.swift

Fix swapped "link" and "signIn" methods for oauth

* npm run changeset

* Update .changeset/fifty-eels-notice.md

* Update .changeset/fifty-eels-notice.md

---------

Co-authored-by: Robin Genz <mail@robingenz.dev>
  • Loading branch information
arstrasser and robingenz authored Jan 10, 2024
1 parent 2b1d4d7 commit f18c6f0
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 4 deletions.
5 changes: 5 additions & 0 deletions .changeset/fifty-eels-notice.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@capacitor-firebase/authentication': patch
---

fix(ios): sign-in with oauth provider failed
Original file line number Diff line number Diff line change
Expand Up @@ -53,8 +53,8 @@ class OAuthProviderHandler: NSObject {
return
}
if let credential = credential {
self.pluginImplementation.handleSuccessfulLink(credential: credential, idToken: nil, nonce: nil,
accessToken: nil, serverAuthCode: nil, displayName: nil, authorizationCode: nil)
self.pluginImplementation.handleSuccessfulSignIn(credential: credential, idToken: nil, nonce: nil,
accessToken: nil, displayName: nil, authorizationCode: nil, serverAuthCode: nil)
}
}
}
Expand All @@ -66,8 +66,8 @@ class OAuthProviderHandler: NSObject {
return
}
if let credential = credential {
self.pluginImplementation.handleSuccessfulSignIn(credential: credential, idToken: nil, nonce: nil,
accessToken: nil, displayName: nil, authorizationCode: nil, serverAuthCode: nil)
self.pluginImplementation.handleSuccessfulLink(credential: credential, idToken: nil, nonce: nil,
accessToken: nil, serverAuthCode: nil, displayName: nil, authorizationCode: nil)
}
}
}
Expand Down

0 comments on commit f18c6f0

Please sign in to comment.