Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug(authentication): No user is signed in #524

Closed
5 of 16 tasks
selvaganes opened this issue Dec 17, 2023 · 3 comments · Fixed by #538
Closed
5 of 16 tasks

bug(authentication): No user is signed in #524

selvaganes opened this issue Dec 17, 2023 · 3 comments · Fixed by #538

Comments

@selvaganes
Copy link

Plugin(s)

  • Analytics
  • App
  • App Check
  • Authentication
  • Crashlytics
  • Cloud Firestore
  • Cloud Messaging
  • Cloud Storage
  • Performance
  • Remote Config

Version

5.3.0

Platform(s)

  • Android
  • iOS
  • Web

Current behavior

When doing signInWithYahoo this error shows:-
To Native -> FirebaseAuthentication signInWithYahoo 48551500
[ FirebaseAuthentication ] No user is signed in.
ERROR MESSAGE: {"errorMessage":"No user is signed in.","message":"No user is signed in."}
⚡️ [error] - {"errorMessage":"No user is signed in.","message":"No user is signed in."}
⚡️ To Native -> FirebaseAuthentication signInWithYahoo 48551501

Expected behavior

Should SignIn as per 5.2.0

Reproduction

Its based on your Example code

Steps to reproduce

const signInWithYahoo = async () => {
const result = await FirebaseAuthentication.signInWithYahoo();
return result.user;
};

Other information

No response

Capacitor doctor

💊 Capacitor Doctor 💊

Latest Dependencies:

@capacitor/cli: 5.6.0
@capacitor/core: 5.6.0
@capacitor/android: 5.6.0
@capacitor/ios: 5.6.0

Installed Dependencies:

@capacitor/android: 5.5.1
@capacitor/core: 5.5.1
@capacitor/cli: 5.5.1
@capacitor/ios: 5.5.1

[success] iOS looking great! 👌
[success] Android looking great! 👌

Before submitting

  • I have read and followed the bug report guidelines.
  • I have attached links to possibly related issues and discussions.
  • I understand that incomplete issues (e.g. without reproduction) are closed.
Copy link
Contributor

This issue has been labeled as needs: reproduction. This label is added to issues that need a code reproduction.

Please provide a Minimal, Reproducible Example using this template in a public GitHub repository so we can debug the issue.

If you have already provided a code snippet and are seeing this message, it is likely that the code snippet was not enough for us to reproduce the issue.

@robingenz robingenz changed the title bug: bug: No user is signed in Dec 26, 2023
@robingenz robingenz changed the title bug: No user is signed in bug(authentication): No user is signed in Dec 26, 2023
@arstrasser
Copy link
Contributor

I am able to reproduce with oauth log in with Microsoft.

Isolated the issue to startSignInFlow() and startLinkFlow() in the /packages/authentication/ios/Plugin/Handlers/OAuthProviderHandler.swift file where handleSuccessfulSignIn and handleSuccessfulLink are swapped.

Swapping these two calls to where they should go resolves the issue for signInWithMicrosoft (and I strongly suspect this would fix Yahoo as well).

@selvaganes
Copy link
Author

Not really sure yet but I think this is a firebase bug. However on the Firebase SDK when I set setCustomParameters with prompt: 'select_account' it works fine. If prompt:'login' is used it fails. On capacitor-firebase it fails on everything.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants