Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: make before/after items an array in schema test #2465

Merged
merged 1 commit into from
Feb 10, 2019

Conversation

kyrofa
Copy link
Contributor

@kyrofa kyrofa commented Feb 8, 2019

  • Have you followed the guidelines for contributing?
  • Have you signed the CLA?
  • If this is a bugfix. Have you checked that there is a bug report open for the issue you are trying to fix on bug reports?
  • If this is a new feature. Have you discussed the design on the forum?
  • Have you successfully run ./runtests.sh static?
  • Have you successfully run ./runtests.sh tests/unit?

The theory for why this doesn't always fail is because, as of 2a2f798, the schema is no longer an ordered dict, which makes the order in which validation finds multiple issues non-deterministic.

(We should consider ordering the loaded json, this may cause other issues)

@kyrofa kyrofa force-pushed the bugfix/before_after_array branch from 071afac to b6060d3 Compare February 8, 2019 22:33
The theory for why this doesn't always fail is because, as of
2a2f798, the schema is no longer an
ordered dict, which makes the order in which validation finds multiple
issues non-deterministic.

Signed-off-by: Kyle Fazzari <kyrofa@ubuntu.com>
@kyrofa kyrofa force-pushed the bugfix/before_after_array branch from b6060d3 to 82c08a1 Compare February 8, 2019 22:49
@codecov-io
Copy link

codecov-io commented Feb 9, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@2a2f798). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #2465   +/-   ##
=========================================
  Coverage          ?   89.89%           
=========================================
  Files             ?      196           
  Lines             ?    13041           
  Branches          ?     1976           
=========================================
  Hits              ?    11723           
  Misses            ?      905           
  Partials          ?      413

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2a2f798...82c08a1. Read the comment docs.

@sergiusens sergiusens merged commit 65720f4 into canonical:master Feb 10, 2019
@kyrofa kyrofa deleted the bugfix/before_after_array branch February 10, 2019 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants