Skip to content

Commit

Permalink
tests: make before/after items an array in schema test (#2465)
Browse files Browse the repository at this point in the history
The theory for why this doesn't always fail is because, as of
2a2f798, the schema is no longer an
ordered dict, which makes the order in which validation finds multiple
issues non-deterministic.

Signed-off-by: Kyle Fazzari <kyrofa@ubuntu.com>
  • Loading branch information
Kyle Fazzari authored and sergiusens committed Feb 10, 2019
1 parent 2a2f798 commit 65720f4
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions tests/unit/project/test_schema.py
Original file line number Diff line number Diff line change
Expand Up @@ -163,8 +163,8 @@ class DaemonDependencyTest(ValidationBaseTest):
"post-stop-command",
dict(option="post-stop-command", value="binary1 --post-stop"),
),
("before", dict(option="before", value="service2")),
("after", dict(option="after", value="service2")),
("before", dict(option="before", value=["service2"])),
("after", dict(option="after", value=["service2"])),
]

def test_daemon_dependency(self):
Expand Down

0 comments on commit 65720f4

Please sign in to comment.