Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ruby plugin: support new download URL #2466

Merged
merged 2 commits into from
Feb 11, 2019

Conversation

kyrofa
Copy link
Contributor

@kyrofa kyrofa commented Feb 10, 2019

  • Have you followed the guidelines for contributing?
  • Have you signed the CLA?
  • If this is a bugfix. Have you checked that there is a bug report open for the issue you are trying to fix on bug reports?
  • If this is a new feature. Have you discussed the design on the forum?
  • Have you successfully run ./runtests.sh static?
  • Have you successfully run ./runtests.sh tests/unit?

This PR resolves LP: #1815336 by supporting the new URL required to download Ruby 2.6 and above (note that it's backward compatible, the older versions are available at this URL as well).

LP: #1815336

Signed-off-by: Kyle Fazzari <kyrofa@ubuntu.com>
@kyrofa kyrofa force-pushed the bugfix/1815336/ruby_url branch from daca554 to 4f74bcf Compare February 10, 2019 08:41
@codecov-io
Copy link

Codecov Report

Merging #2466 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2466      +/-   ##
==========================================
+ Coverage   89.89%   89.89%   +<.01%     
==========================================
  Files         196      196              
  Lines       13041    13043       +2     
  Branches     1976     1976              
==========================================
+ Hits        11723    11725       +2     
  Misses        905      905              
  Partials      413      413
Impacted Files Coverage Δ
snapcraft/plugins/ruby.py 98.86% <100%> (+0.02%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 65720f4...566bf30. Read the comment docs.

Copy link
Contributor

@cmatsuoka cmatsuoka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correctly extracts feature from version number and add it to URL.

@sergiusens sergiusens merged commit fad0358 into canonical:master Feb 11, 2019
@kyrofa kyrofa deleted the bugfix/1815336/ruby_url branch February 11, 2019 17:52
kyrofa pushed a commit to kyrofa/snapcraft that referenced this pull request Feb 11, 2019
LP: #1815336

Signed-off-by: Kyle Fazzari <kyrofa@ubuntu.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants