Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not able to persist a description field when creating a new storage volume snapshot #14011

Closed
gabrielmougard opened this issue Aug 29, 2024 · 3 comments
Assignees
Labels
Bug Confirmed to be a bug
Milestone

Comments

@gabrielmougard
Copy link
Contributor

gabrielmougard commented Aug 29, 2024

The Description field from api.StorageVolumeSnapshotPut is not used (when creating a storage volume snapshot from a YAML config in the CLI ) by api.StorageVolumeSnapshotsPost, which does not contain a Description field. This leads to the fact that when a volume snapshot is being taken, the created volume entry in the DB uses the description of the parent volume and not the description of the snapshot. Do we want to fix this or is it not a bug?

@gabrielmougard gabrielmougard added the Maybe Undecided whether in scope for the project label Aug 29, 2024
@gabrielmougard gabrielmougard self-assigned this Aug 29, 2024
@tomponline
Copy link
Member

Yes I think its a bug. We likely need to add a new field to api.StorageVolumeSnapshotsPost

@MusicDin please could you remind me of the PR you worked on last year to separate some of the Post and Put structs so the former didn't embed the latter, I would like to refresh myself on that discussion. Ta

@tomponline tomponline added Bug Confirmed to be a bug and removed Maybe Undecided whether in scope for the project labels Aug 29, 2024
@tomponline tomponline added this to the lxd-6.2 milestone Aug 29, 2024
@MusicDin
Copy link
Member

Here: #13035

@gabrielmougard
Copy link
Contributor Author

@MusicDin @tomponline #14016 should solve that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Confirmed to be a bug
Projects
None yet
Development

No branches or pull requests

3 participants