Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

API: Unembed Put structs from Get structs #13035

Merged
merged 42 commits into from
Mar 7, 2024
Merged

API: Unembed Put structs from Get structs #13035

merged 42 commits into from
Mar 7, 2024

Conversation

MusicDin
Copy link
Member

@MusicDin MusicDin commented Mar 4, 2024 •
edited by tomponline
Loading

Unembed Put structs from Get structs.

Fixes #12993

@github-actions github-actions bot added the API Changes to the REST API label Mar 4, 2024
MusicDin
MusicDin commented Mar 4, 2024
View reviewed changes
lxd/patches.go Outdated Show resolved Hide resolved
@github-actions github-actions bot added the Documentation Documentation needs updating label Mar 4, 2024
@MusicDin MusicDin force-pushed the fix/embed-structs branch 2 times, most recently from 504682c to ced2da7 Compare March 5, 2024 15:14
@MusicDin MusicDin marked this pull request as ready for review March 5, 2024 20:45
tomponline
tomponline requested changes Mar 6, 2024
View reviewed changes
Copy link
Member

@tomponline tomponline left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some changes needed thanks!

@tomponline
Copy link
Member

@MusicDin please may you rebase on #13045 as i intend to merge that one before this and it contains some API struct changes.

@MusicDin MusicDin force-pushed the fix/embed-structs branch 3 times, most recently from ed85ecd to 76f3823 Compare March 6, 2024 16:04
@tomponline tomponline changed the title Unembed api Put structs from Get structs API: Unembed Put structs from Get structs Mar 6, 2024
@tomponline
Copy link
Member

@MusicDin ive merged #13045 so can be rebased now.

@MusicDin MusicDin force-pushed the fix/embed-structs branch 2 times, most recently from 3c5054a to 877ccbf Compare March 6, 2024 16:22
@MusicDin
lxd/project/permissions: Update reference to instance entity fields
d9518cc 
Signed-off-by: Din Music <din.music@canonical.com>
@MusicDin
lxd/instance/drivers: Update references to instance snapshot entity f…
d0588b0 
…ields

Signed-off-by: Din Music <din.music@canonical.com>
@MusicDin
lxd/instances_post: Update references to instance entity fields
4014653 
Signed-off-by: Din Music <din.music@canonical.com>
@MusicDin
lxd/patches: Update fields of api entities
d282513 
Signed-off-by: Din Music <din.music@canonical.com>
@MusicDin
lxd/profiles: Update references to profile entity fields
a7b7c6e 
Signed-off-by: Din Music <din.music@canonical.com>
@MusicDin
lxd/api_internal_test: Update references to profile entity fields
cbd08b7 
Signed-off-by: Din Music <din.music@canonical.com>
@MusicDin
lxd/api_cluster: Update fields of api entities
0588643 
Signed-off-by: Din Music <din.music@canonical.com>
tomponline
tomponline previously approved these changes Mar 6, 2024
View reviewed changes
Copy link
Member

@tomponline tomponline left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@MusicDin
Copy link
Member Author

MusicDin commented Mar 6, 2024

Seems I've broke something.. Looking into it.

@MusicDin
lxd/api_internal_recover: Update fields of storage pool api entities
e321fa7 
Signed-off-by: Din Music <din.music@canonical.com>
@MusicDin
lxd/storage/backend_lxd: Update references to storage_pool entity fields
52f964c 
Signed-off-by: Din Music <din.music@canonical.com>
@MusicDin
lxd/network/*: Update references to network entity fields
0d308d1 
Signed-off-by: Din Music <din.music@canonical.com>
@MusicDin
lxd/auth_groups: Update fields of api entities
82ac4da 
Signed-off-by: Din Music <din.music@canonical.com>
@MusicDin
lxd/identities: Update fields of api entities
7a15812 
Signed-off-by: Din Music <din.music@canonical.com>
@MusicDin
lxd/certificates: Update certificate post struct
757e0d0 
Signed-off-by: Din Music <din.music@canonical.com>
@MusicDin
lxd-user/lxd: Update certificate post struct
5c1b82c 
Signed-off-by: Din Music <din.music@canonical.com>
@MusicDin
lxc: Update fields of api entities
0631dd4 
Signed-off-by: Din Music <din.music@canonical.com>
@MusicDin
i18n: Update translations
8d54ceb 
Signed-off-by: Din Music <din.music@canonical.com>
@MusicDin
doc: Update api definition
b8cbda8 
Signed-off-by: Din Music <din.music@canonical.com>
@tomponline
Copy link
Member

@MusicDin it looks fixed now, what was the issue? Thanks

@MusicDin
Copy link
Member Author

MusicDin commented Mar 7, 2024

Yep. I accidentally unset Driver field in StoragePool struct (in lxd/api_internal_recover) when changing to SetWritable().

@tomponline tomponline merged commit 6ea892c into canonical:main Mar 7, 2024
28 checks passed
@tomponline
Copy link
Member

Thanks!

@MusicDin MusicDin deleted the fix/embed-structs branch March 7, 2024 08:32
@samuelallan72 samuelallan72 mentioned this pull request Jun 17, 2024
Closed
6 tasks
@MusicDin MusicDin mentioned this pull request Aug 30, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markylaing markylaing markylaing left review comments

@tomponline tomponline tomponline approved these changes

Assignees
No one assigned
Labels
API Changes to the REST API Documentation Documentation needs updating
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

API: Stop embedding post & put structs in info structs to avoid inappropriate fields being present
3 participants
@MusicDin @tomponline @markylaing