-
Notifications
You must be signed in to change notification settings - Fork 930
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
lxc: allow creation of various resources from YAML (from Incus) #13995
lxc: allow creation of various resources from YAML (from Incus) #13995
Conversation
4d43a9c
to
fd0dacb
Compare
I guess the cluster test suite iis broken because of the new dqlite ppa? The rest of the tests seem ok. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@gabrielmougard before I go any further, please can you go through this PR (and your earlier related ones) and double check that the whole of the Put
data being read in is actually being applied, and that the name of the resource isn't being overridden from stdin too, as it looks like at least some of these cherry-picks are only taking the Config from the Put structure and not things like Description.
c59bce0
to
39eecc0
Compare
It should be fixed now. I also opened this related issue: #14011 |
@gabrielmougard did you also review your earlier PRs https://github.com/canonical/lxd/pulls?q=is%3Apr+is%3Aclosed+author%3Agabrielmougard+lxc for similar issues that I missed before? |
@tomponline is it possible to review and merge that PR before merging this PR? |
@tomponline After reading these past PRs, I noticed I missed adding a |
Yes please |
`lxc network forward create` already has support for creation from a yaml configuration file, but the same wasn't printed in the usage information of the command. Signed-off-by: Vishesh Agrawal <agrawal.vishesh.178@gmail.com> (cherry picked from commit 07395fa051955611579148c76cd5ab4aed13e041) Signed-off-by: Gabriel Mougard <gabriel.mougard@canonical.com> License: Apache-2.0
`lxc network acl create` already has support for creation from a yaml configuration file, but the same wasn't printed in the usage information of the command. Signed-off-by: Vishesh Agrawal <agrawal.vishesh.178@gmail.com> (cherry picked from commit e728bf77ff7f58cdd14bcb78acb519056ab6f5ad) Signed-off-by: Gabriel Mougard <gabriel.mougard@canonical.com> License: Apache-2.0
Signed-off-by: Gabriel Mougard <gabriel.mougard@canonical.com>
Signed-off-by: Gabriel Mougard <gabriel.mougard@canonical.com>
Signed-off-by: Vishesh Agrawal <agrawal.vishesh.178@gmail.com> (cherry picked from commit c64a3f39f2556a86a2b58f95eeaba0c1b57ea5ad) Signed-off-by: Gabriel Mougard <gabriel.mougard@canonical.com> License: Apache-2.0
Signed-off-by: Gabriel Mougard <gabriel.mougard@canonical.com>
c0c4ea4
to
a15a0e4
Compare
Signed-off-by: Gabriel Mougard <gabriel.mougard@canonical.com>
Signed-off-by: Vishesh Agrawal <agrawal.vishesh.178@gmail.com> (cherry picked from commit 0864637abefc63a55f516f598a4c2f1581f52a87) Signed-off-by: Gabriel Mougard <gabriel.mougard@canonical.com> License: Apache-2.0 Signed-off-by: Gabriel Mougard <gabriel.mougard@canonical.com>
Signed-off-by: Gabriel Mougard <gabriel.mougard@canonical.com>
Signed-off-by: Gabriel Mougard <gabriel.mougard@canonical.com>
Signed-off-by: Vishesh Agrawal <agrawal.vishesh.178@gmail.com> (cherry picked from commit 58dc074fbad8d7049f4a52c7c3c0685fd72f856f) Signed-off-by: Gabriel Mougard <gabriel.mougard@canonical.com> License: Apache-2.0
Signed-off-by: Vishesh Agrawal <agrawal.vishesh.178@gmail.com> Signed-off-by: Gabriel Mougard <gabriel.mougard@canonical.com> License: Apache-2.0 Signed-off-by: Gabriel Mougard <gabriel.mougard@canonical.com>
Signed-off-by: Gabriel Mougard <gabriel.mougard@canonical.com>
Signed-off-by: Vishesh Agrawal <agrawal.vishesh.178@gmail.com> (cherry picked from commit d42cd0136dca95c1e9cb78d5a0438e215efe3ece) Signed-off-by: Gabriel Mougard <gabriel.mougard@canonical.com> License: Apache-2.0 Signed-off-by: Gabriel Mougard <gabriel.mougard@canonical.com>
Signed-off-by: Gabriel Mougard <gabriel.mougard@canonical.com>
We need to check that when a bucket key is created with a description, the description is saved correctly to the DB. Signed-off-by: Gabriel Mougard <gabriel.mougard@canonical.com>
Signed-off-by: Gabriel Mougard <gabriel.mougard@canonical.com>
a15a0e4
to
4edd778
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
cherry-picked from: lxc/incus#786
cherry-picked from: lxc/incus#782
cherry-picked from: lxc/incus#778
cherry-picked from: lxc/incus#775
cherry-picked from: lxc/incus#767
cherry-picked from: lxc/incus#863
cherry-picked from: lxc/incus#864
cherry-picked from: lxc/incus#891