Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(changelog): add entry for 4.4.1 #630

Merged
merged 9 commits into from
Feb 4, 2025
Merged

docs(changelog): add entry for 4.4.1 #630

merged 9 commits into from
Feb 4, 2025

Conversation

mr-cal
Copy link
Contributor

@mr-cal mr-cal commented Feb 4, 2025 •
edited
Loading

  • Have you followed the guidelines for contributing?
  • Have you signed the CLA?
  • Have you successfully run tox?
  • Have you added an entry to the changelog (docs/reference/changelog.rst)?

Unblocks canonical/snapcraft#5221
(CRAFT-4035)

@mr-cal mr-cal added the rebase label Feb 4, 2025
lengau and others added 6 commits February 4, 2025 10:27
@lengau @mr-cal
style(ruff): fix linting issues from ruff update (#580)
8a6f948
@mr-cal
chore: add exceptions for stdlib module shadowing (#603)
5d0ea97 
Signed-off-by: Callahan Kovacs <callahan.kovacs@canonical.com>
@tigarmo @mr-cal
chore(lint): get around a Pydantic 2.10.x type bug (#566)
88465f7 
Both mypy and pyright complain that the "field.default_factory()" call has too
few arguments, even though its type is typing.Callable[[], Any]. It should be
fixed soon, and in the meantime we can ignore the spurious error.

Ref: pydantic/pydantic#10945
@tigarmo @mr-cal
chore: use 'candidate' fetch-service (#547)
66be3e6
@tigarmo @lengau @mr-cal
fix(tests): fix a test broken in Python 3.12.8 (#595)
5d34b48 
Since 3.12.8, argparse 'choices' are no longer quoted.
Ref: python/cpython#11776

---------

Co-authored-by: Alex Lowe <alex.lowe@canonical.com>
@dariuszd21 @mr-cal
fix: use artifact in fetch-service context (#587)
65da696 
Signed-off-by: Dariusz Duda <dariusz.duda@canonical.com>
@lengau
Copy link
Contributor

lengau commented Feb 4, 2025

docs build failure is unrelated but we probably need to fix it before we merge this.

dariuszd21 and others added 3 commits February 4, 2025 11:15
@dariuszd21 @mr-cal
ci(rtd): pin python version to 3.12 (#562)
b8c4ae5
@mr-cal
fix(launchpad): use the project's privacy for repos and recipes (#615)
e12fdc1 
Signed-off-by: Callahan Kovacs <callahan.kovacs@canonical.com>
@mr-cal
docs(changelog): add entry for 4.4.1
872686d 
Signed-off-by: Callahan Kovacs <callahan.kovacs@canonical.com>
@mr-cal
Copy link
Contributor Author

mr-cal commented Feb 4, 2025

docs build failure is unrelated but we probably need to fix it before we merge this.

Agreed. I found the commit that fixed that problem.

@mr-cal mr-cal requested a review from a team February 4, 2025 17:39
@lengau lengau requested review from medubelko and a team February 4, 2025 18:23
@mr-cal mr-cal removed the request for review from a team February 4, 2025 20:14
@mr-cal mr-cal merged commit 2dedbc4 into hotfix/4.4 Feb 4, 2025
15 checks passed
@mr-cal mr-cal deleted the release/4.4.1 branch February 4, 2025 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lengau lengau lengau approved these changes

@medubelko medubelko medubelko approved these changes

Assignees
No one assigned
Labels
rebase
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mr-cal @lengau @medubelko @tigarmo @dariuszd21