New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(launchpad): use the project's privacy for repos and recipes #615

Merged

lengau merged 4 commits into main from work/CRAFT-3984-private-repos

Jan 29, 2025

Contributor

mr-cal commented Jan 27, 2025 •

edited

Loading

Have you followed the guidelines for contributing?
Have you signed the CLA?
Have you successfully run tox?

Fixes a bug where the remote-builder would create a public repository and recipe, even when the project is private.

This is a backward-compatible change, but raises a deprecation warning if a project could be public.

I tested with snapcraft and can confirm the recipe and repo are private.

Fixes #614
(CRAFT-3984)


          fix(launchpad): use project privacy for repo and recipe

baa213c

Signed-off-by: Callahan Kovacs <callahan.kovacs@canonical.com>

Contributor Author

mr-cal commented Jan 27, 2025

@lengau, can I get a pre-review from you? I'm waiting to write unit tests until after I get your feedback on the design.

mr-cal commented

View reviewed changes

craft_application/launchpad/launchpad.py Outdated Show resolved Hide resolved

mr-cal requested a review from lengau

January 27, 2025 23:01

lengau reviewed

View reviewed changes

craft_application/launchpad/models/recipe.py Show resolved Hide resolved

lengau reviewed

View reviewed changes

craft_application/services/remotebuild.py Show resolved Hide resolved


          chore: API changes from review

150234d

Signed-off-by: Callahan Kovacs <callahan.kovacs@canonical.com>

mr-cal requested a review from lengau

January 28, 2025 16:15

Contributor

lengau commented Jan 28, 2025

Current implementation looks good

mr-cal added the squash label

mr-cal changed the title ~~fix(launchpad): use project privacy for repo and recipe~~ fix(launchpad): use the project's privacy for repos and recipes


          tests: unit tests

Signed-off-by: Callahan Kovacs <callahan.kovacs@canonical.com>

mr-cal commented

View reviewed changes

craft_application/launchpad/models/base.py Show resolved Hide resolved

mr-cal requested a review from bepri

January 28, 2025 21:37

lengau reviewed

View reviewed changes

tests/unit/services/test_remotebuild.py Show resolved Hide resolved

mr-cal requested a review from lengau

January 28, 2025 23:06

bepri approved these changes

View reviewed changes

Contributor

bepri left a comment

Looks good! I think Alex's pre-review caught pretty much everything I would've. Just a lil nitpick:

tests/unit/services/conftest.py Outdated Show resolved Hide resolved


          chore: use enum

9f9e1ef

Signed-off-by: Callahan Kovacs <callahan.kovacs@canonical.com>

mr-cal mentioned this pull request

remote build: use the project's privacy for repos and recipes canonical/snapcraft#5221

Closed

lengau reviewed

View reviewed changes

Contributor

lengau left a comment

Review status: I'm happy with the full design etc., but we probably need to hop in a call to figure out the private vs proprietary situation

lengau approved these changes

View reviewed changes

lengau merged commit 7c7f406 into main

9 checks passed

lengau deleted the work/CRAFT-3984-private-repos branch

January 29, 2025 18:35

lengau pushed a commit that referenced this pull request


          fix(launchpad): use the project's privacy for repos and recipes (#615)

a98336d

Signed-off-by: Callahan Kovacs <callahan.kovacs@canonical.com>

mr-cal mentioned this pull request

docs: update changelog, add PR checklist item #624

Merged

3 tasks

mr-cal added a commit that referenced this pull request


          fix(launchpad): use the project's privacy for repos and recipes (#615)

e100c8d

Signed-off-by: Callahan Kovacs <callahan.kovacs@canonical.com>

mr-cal mentioned this pull request

docs(changelog): add entry for 4.4.1 #630

Merged

4 tasks

mr-cal added a commit that referenced this pull request


          fix(launchpad): use the project's privacy for repos and recipes (#615)

ce3e749

Signed-off-by: Callahan Kovacs <callahan.kovacs@canonical.com>

mr-cal added a commit that referenced this pull request


          fix(launchpad): use the project's privacy for repos and recipes (#615)

e12fdc1

Signed-off-by: Callahan Kovacs <callahan.kovacs@canonical.com>

mr-cal added a commit that referenced this pull request


          fix(launchpad): use the project's privacy for repos and recipes (#615)

b394bdd

Signed-off-by: Callahan Kovacs <callahan.kovacs@canonical.com>

mr-cal mentioned this pull request

fix(remotebuild): use the project's privacy for repos and recipes canonical/snapcraft#5238

Merged

4 tasks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels