Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use artifact in fetch-service context #587

Merged
merged 5 commits into from
Jan 16, 2025

Conversation

dariuszd21
Copy link
Contributor

@dariuszd21 dariuszd21 commented Dec 10, 2024

  • Have you followed the guidelines for contributing?
  • Have you signed the CLA?
  • Have you successfully run tox?

Changes required to make fetch-service work after artefact -> artifact change (released in v0.6).

Copy link

codecov bot commented Dec 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (hotfix/4.8@e958464). Learn more about missing BASE report.

Additional details and impacted files
@@              Coverage Diff              @@
##             hotfix/4.8     #587   +/-   ##
=============================================
  Coverage              ?   90.39%           
=============================================
  Files                 ?       66           
  Lines                 ?     3989           
  Branches              ?      454           
=============================================
  Hits                  ?     3606           
  Misses                ?      295           
  Partials              ?       88           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dariuszd21 dariuszd21 force-pushed the work/fix-fetch-service branch from 3f6fdaf to 61a2afb Compare January 14, 2025 18:56
@dariuszd21 dariuszd21 marked this pull request as ready for review January 14, 2025 18:58
Copy link
Contributor

@cmatsuoka cmatsuoka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢 it!

dariuszd21 and others added 4 commits January 15, 2025 11:14
Signed-off-by: Dariusz Duda <dariusz.duda@canonical.com>
Signed-off-by: Dariusz Duda <dariusz.duda@canonical.com>
Signed-off-by: Dariusz Duda <dariusz.duda@canonical.com>
@dariuszd21 dariuszd21 force-pushed the work/fix-fetch-service branch from 61a2afb to eba033b Compare January 15, 2025 16:19
@dariuszd21 dariuszd21 changed the base branch from main to hotfix/4.8 January 15, 2025 16:19
@dariuszd21 dariuszd21 changed the title chore: use artifact in fetch-service context fix: use artifact in fetch-service context Jan 15, 2025

For a complete list of commits, check out the `4.8.2`_ release on GitHub.

4.8.1 (2025-Jan-13)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added date here as well @lengau.
I think that once it lands, we can merge both at once with #605

Signed-off-by: Dariusz Duda <dariusz.duda@canonical.com>
@lengau lengau merged commit 0ad817c into canonical:hotfix/4.8 Jan 16, 2025
10 checks passed
@dariuszd21 dariuszd21 deleted the work/fix-fetch-service branch January 16, 2025 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants