v8 & v9 stuff #982
v8 & v9 stuff #982
Conversation
…oji, updated components example
…om select menu to MessageComponentInteractionData, added missing value to Interaction
# Conflicts: # interactions.go
There was a problem hiding this comment.
In all, I think there's a lot of promising stuff here. Select menus have had an outstanding PR in #954, and it seems like they'll be ready to go shortly; given that it has been open for a lot longer, I envision that getting merged over your implementation here. That said, I think that the remainder of what's here has great potential. I do think that your renaming of the ComponentType and ButtonStyle constants make sense; sometimes it's hard to see the big picture when you're deep in the weeds reviewing things, but that is more consistent overall.
We'll see what needs to be done in terms of merge conflict resolution when that time comes (hopefully soon).
…rFormat, ArchiveDuration time unit mistake in comment fixed
There was a problem hiding this comment.
Edit: I misinterpreted the situation by looking more closely at the times at which the PRs happened rather than the commits. I'm really sorry about what I threw out here, though know that it'll be just the same the other way around. There are still some things that can be worked on here, but I hope that we can still more forward.
|
Well I have no idea what happened here, but it looks like there was some conflict over my pr's commits looking very identical to another person's code. I'd like to add in here by saying I never looked at the other PRs and that might be my own mistake. I'm looking forward to see what I can do next in this PR, and thank you for clearing things up |
|
Hey guys, is there anything I can help with to get these features in the upstream? Is there something missing in the implementation? |
Add ThreadEdit function
# Conflicts: # components.go # examples/components/main.go # interactions.go # message.go # webhook.go
|
With permission from @Pedro-Pessoa, the author of #922 , I've gone ahead and moved their work into my branch so we can continue from here, as well as resolve the merge conflicts. If I'm missing anything from there, let me know. In addition, ThreadEdit from https://github.com/vysiondev/discordgo/pull/1 was replaced in favor of ThreadEditComplex. |
|
Maybe woth mentioning @Pedro-Pessoa just in case he didn see this? |
|
Bumped into this too. How is this PR going and is there anything that you need help to get this reviewed? |
|
It would probably be best if this PR was split up into multiple PRs. It's quite large, and has a lot of features in it, and will probably cause code fatigue for even the most prolific reviewers. It's been my experience that the larger the PR, the more likely it will sort of pile up into a logjam. |
|
Any progress? |
|
Alright. Since the PR is apparently abandoned, here's an overview of features implementation described in this PR for the future readers:
|
First off, sorry about any confusion for my past PRs, I am still not too familiar with git. This time I tried and made sure everything was set up correctly before opening. If it's caused any trouble when I randomly close a PR, i apologize.
InviteComplex(), which gets invite information from the API with an option to includewith_countsandwith_expiration. Currently,InviteWithCounts()was the only way to retrieve # of uses of the invite, and there was no way to access the expiration date of the invite.The new component, Select Menus. The components example has also been updated accordingly.Already implemented by a different PR.