-
Notifications
You must be signed in to change notification settings - Fork 822
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Threads reloaded #1058
Threads reloaded #1058
Conversation
🚧 This is still under development |
Woah, that went pretty fast. Anyways, should be everything now. |
@CarsonHoffman Take a look |
Huge ++ to this work, and I would love to have Thread support on DiscordGo also. Appreciate if @CarsonHoffman could make this happen. |
Bumped! Thanks for your work and how is this going? I am looking forward to have Thread supported any time soon! |
Well, I think by now everything is finished, just waiting when @CarsonHoffman does review on this. |
@CarsonHoffman and @FedorLap2006 👋 - checking in if this pull is ready to go? |
Almost. If I didn't forget anything then it's gonna be only the |
So we're just waiting for @CarsonHoffman to provide their input on the |
Yes. |
This would be really cool extension to what the library already allows for. Would love to see this land sooner than later. @CarsonHoffman any chance we can bump this up in the queue of things to get to? thanks in advance, |
This reverts commit 4ca359f.
Implements updating message id in MESSAGE_CREATE and MESSAGE_DELETE events. Refer to https://discord.com/developers/docs/topics/gateway#thread-update for more info.
@CarsonHoffman I think it's ready for the final review. |
@FedorLap2006 I found a missing threadID assignment intended here: (added snippet)
|
After deeper reading of Discord's documentation and our current source code, I've come to the conclusion that Carson with right, about |
fd22e06
to
60ac5bc
Compare
There are a couple of problems (it deletes some threads rest methods) with merge of |
60ac5bc
to
b1bb26d
Compare
bad9909
to
a4c5375
Compare
So, seeing still ongoing problem with lack of threads implementation, I decided to make my own PR on them.
This PR should include everything that's on threads currently.
This PR also includes some code from #982 and #922 (it is meant to be continuation of those two, but written from scratch). So credits to the authors.
The roadmap