Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use structs for all JSON data sent to Discord #1

Closed
bwmarrin opened this issue Nov 25, 2015 · 2 comments
Closed

Use structs for all JSON data sent to Discord #1

bwmarrin opened this issue Nov 25, 2015 · 2 comments
Milestone
v0.6.0

Comments

@bwmarrin
Copy link
Owner

Some parts of the library are using either interface map or strings for json data sent to Discord. This must be changed so that everything goes though an anonymous struct then marshaled properly and send to Discord.
@bwmarrin bwmarrin added this to the v0.6.0 milestone Dec 17, 2015
@bwmarrin bwmarrin changed the title Use anonymous structs for all JSON sent to Discord Use structs for all JSON data sent to Discord Dec 20, 2015
@bwmarrin
Copy link
Owner Author

At this point REST API and Data WS are both using structs. Working on the voice.go file now.

@bwmarrin
Copy link
Owner Author

All data sent via either strings or interface mapped have been converted to using actual structs.

@bwmarrin bwmarrin mentioned this issue Jan 21, 2016
Merged
Vindexus pushed a commit to monstercat/discordgo that referenced this issue Oct 18, 2019
@otothea
Merge pull request bwmarrin#1 from otothea/feature/configurable-voice…
d3d8646 
…-rates

add support for configurable opus rate/size
@onestep749 onestep749 mentioned this issue Oct 24, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.6.0
Development

No branches or pull requests
1 participant
@bwmarrin