Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Revert https://github.com/brave/browser-laptop/commit/7527e4f6718e905… #9151

Merged
merged 1 commit into from
Jun 2, 2017
Merged

Revert https://github.com/brave/browser-laptop/commit/7527e4f6718e905… #9151

merged 1 commit into from
Jun 2, 2017

Conversation

luixxiul
Copy link
Contributor

@luixxiul luixxiul commented May 30, 2017

…6b5445a2091f2a6c9b90355bc

See: #3653 (comment), #9034 (comment)

Follow-up to #9034

Auditors:

Test Plan:

  1. Click Bravery panel button next to the URL bar
  2. Make sure darkening effect does not occur

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).

Test Plan:

Reviewer Checklist:

Tests

  • Adequate test coverage exists to prevent regressions
  • Tests should be independent and work correctly when run individually or as a suite ref
  • New files have MPL2 license header

See: #3653 (comment), #9034 (comment)

Auditors:

Test Plan:
1. Click Bravery panel button next to the URL bar
2. Make sure darkening effect does not occur
@luixxiul luixxiul added the design A design change, especially one which needs input from the design team. label May 30, 2017
@luixxiul luixxiul added this to the 0.18.x milestone May 30, 2017
@luixxiul luixxiul self-assigned this May 30, 2017
@luixxiul luixxiul requested a review from cezaraugusto May 30, 2017 22:57
Copy link
Contributor

@cezaraugusto cezaraugusto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@cezaraugusto cezaraugusto merged commit d87acbe into brave:master Jun 2, 2017
@luixxiul luixxiul deleted the fix-nonModalDialog branch June 2, 2017 04:27
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
design A design change, especially one which needs input from the design team.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants