remove darkening for all non-modal dialogs

[bradleyrichter]

Test plan

Test Plan 1:

1. Open http://browserspy.dk/password.php
2. Click "password-ok.php"
3. Make sure darkening effect does not occur
4. Click the outside of the dialog
5. Make sure the dialog is closed

Test Plan 2:

1. Disable widevine
2. Open netflix.com
3. Make sure widevine dialog with the dark background appears
4. Click the outside of the dialog
5. Make sure the dialog is not closed

Test Plan 3:

1. Click Bravery panel button next to the URL bar
2. Make sure darkening effect does not occur

---

If a dialog can be canceled by clicking outside of it's perimeter, then the browser should not be darkened.

example of improper use:

[lucidNTR]

yes very annoying, will submit PR for this soon

[luixxiul]

@bradleyrichter do you think the background for the bravery panel (which is a dialog but not modal) should be removed as well?

[luixxiul]

It will be like this:

[luixxiul]

pushed a temp fix to apply the gray background to the panel: 7527e4f

[bradleyrichter]

Yes please…

…

On May 25, 2017, at 7:04 AM, Suguru Hirahara ***@***.***> wrote: @bradleyrichter <https://github.com/bradleyrichter> do you think the background for the bravery panel (which is a dialog but not modal) should be removed as well? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#3653 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AM4jqnQ30Fhz_FskjBXSIo30qgY8m_CUks5r9YqAgaJpZM4JzMZK>.

[luixxiul]

ok I'm going to work on that, thanks.