This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
Remove darkening for all non-modal dialogs #9034
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
May 25, 2017 22:59
If 'isClickDismiss' is specified to a Dialog, its background color will be transparent. Otherwise it will be gray. Fix #3653 Auditors: Test Plan 1: 1. Open http://browserspy.dk/password.php 2. Click "password-ok.php" 3. Make sure darkening effect does not occur 4. Click the outside of the dialog 5. Make sure the dialog is closed Test Plan 2: 1. Disable widevine 2. Open netflix.com 3. Make sure widevine dialog with the dark background appears 4. Click the outside of the dialog 5. Make sure the dialog is not closed
| @@ -242,7 +242,7 @@ class BraveryPanel extends ImmutableComponent { | |||
| }) | |||
| const compactBraveryPanel = getSetting(settings.COMPACT_BRAVERY_PANEL) | |||
|
|
|||
| return <Dialog onHide={this.props.onHide} testId='braveryPanelContainer' isClickDismiss> | |||
| return <Dialog onHide={this.props.onHide} testId='braveryPanelContainer' isClickDismiss isBraveryPanel> | |||
There was a problem hiding this comment.
small: let's place isClickDismiss, isBraveryPanel and other props that are true by default in the beginning of component's props. No need to do this now since this component is small enough but please do for future changes. that helps readability and even more for us that do front-end a lot.
I'm going to update our styles doc soon with that info btw
There was a problem hiding this comment.
this commit will be reverted.
|
@cezaraugusto sorry I should have removed the last commit per @bradleyrichter (#3653 (comment)) ... I'll push a fix soon. |
luixxiul
added
design
This was referenced May 30, 2017
8 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If 'isClickDismiss' is specified to a Dialog, its background color will be transparent. Otherwise it will be gray.
Fix #3653
Auditors:
Test Plan 1:
Test Plan 2:
Submitter Checklist:
git rebase -ito squash commits (if needed).Test Plan:
Reviewer Checklist:
Tests