Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Do not warn about the number of subscribers to renderer store state change events #12909

Merged
merged 1 commit into from
Jan 30, 2018

Conversation

petemill
Copy link
Member

Fix #9643

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.
  • Request a security/privacy review as needed. (Ask a Brave employee to help if you cannot access this document.)

Test Plan:

Reviewer Checklist:

  • Request a security/privacy review as needed if one was not already requested.

Tests

  • Adequate test coverage exists to prevent regressions
  • Tests should be independent and work correctly when run individually or as a suite ref
  • New files have MPL2 license header

@codecov-io
Copy link

codecov-io commented Jan 29, 2018

Codecov Report

Merging #12909 into master will decrease coverage by 0.02%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master   #12909      +/-   ##
==========================================
- Coverage   56.13%    56.1%   -0.03%     
==========================================
  Files         279      279              
  Lines       27322    27328       +6     
  Branches     4444     4444              
==========================================
- Hits        15336    15333       -3     
- Misses      11986    11995       +9
Flag Coverage Δ
#unittest 56.1% <100%> (-0.03%) ⬇️
Impacted Files Coverage Δ
js/stores/windowStore.js 27.69% <100%> (+0.13%) ⬆️
js/stores/appStoreRenderer.js 91.66% <100%> (-8.34%) ⬇️
app/renderer/components/reduxComponent.js 84.61% <0%> (-6.16%) ⬇️

@cezaraugusto cezaraugusto added this to the 0.22.x (Nightly Channel) milestone Jan 30, 2018
Copy link
Contributor

@cezaraugusto cezaraugusto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌 I wouldn't change a thing®

@cezaraugusto cezaraugusto merged commit d2a9632 into brave:master Jan 30, 2018
@petemill petemill deleted the fix/issue-9643 branch January 30, 2018 07:40
@petemill petemill mentioned this pull request Jan 31, 2018
10 tasks
@bbondy bbondy modified the milestones: 0.22.x (Developer Channel), 0.23.x (Nightly Channel) Feb 25, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants