Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

"possible EventEmitter memory leak detected" #9643

Closed
crysman opened this issue Jun 21, 2017 · 4 comments
Closed

"possible EventEmitter memory leak detected" #9643

crysman opened this issue Jun 21, 2017 · 4 comments
Assignees
Labels
dev-setup priority/P5 Cosmetic. Spelling, copy, layout. New features (which should also be part of an initiative). QA/no-qa-needed release-notes/exclude

Comments

@crysman
Copy link

crysman commented Jun 21, 2017

  • Did you search for similar issues before submitting this one?
    yes

  • Describe the issue you encountered:

❱ brave
Crash reporting enabled
[4680:4680:0621/142320.244339:ERROR:CONSOLE(33239)] "(node) warning: possible EventEmitter memory leak detected. %d listeners added. Use emitter.setMaxListeners() to increase limit.", source: chrome://brave/usr/share/brave/resources/app.asar/app/extensions/brave/gen/app.entry.js (33239)
[4680:4680:0621/142320.250645:ERROR:CONSOLE(33239)] "(node) warning: possible EventEmitter memory leak detected. %d listeners added. Use emitter.setMaxListeners() to increase limit.", source: chrome://brave/usr/share/brave/resources/app.asar/app/extensions/brave/gen/app.entry.js (33239)

  • Platform (Win7, 8, 10? macOS? Linux distro?):
    GNU/Linux Xubuntu 16.10

  • Brave Version (revision SHA):
    Brave 0.16.12
    rev 72624a2

  • Steps to reproduce:

    1. open terminal
    2. run brave
@bsclifton
Copy link
Member

I don't believe this is serious (it's actually mostly a false positive)- we had fixed the real cases, IIRC

cc: @bbondy and @bridiver who are more familiar with this

@srirambv
Copy link
Collaborator

Has been verified here #8244

@bbondy
Copy link
Member

bbondy commented Jun 27, 2017

It is just because each redux component registers for an event now and it passes the constant threshold for that warning. Let's leave this open just to track removing that warning.

@kenorb
Copy link
Contributor

kenorb commented Aug 15, 2017

Btw. %d listeners added should be populated with the number I guess.

@bsclifton bsclifton added priority/P5 Cosmetic. Spelling, copy, layout. New features (which should also be part of an initiative). and removed priority/low (deprecated) labels Nov 22, 2017
@bsclifton bsclifton added this to the Backlog (Prioritized) milestone Nov 22, 2017
petemill added a commit to petemill/browser-laptop that referenced this issue Jan 29, 2018
@petemill petemill self-assigned this Jan 29, 2018
@cezaraugusto cezaraugusto modified the milestones: Backlog (Prioritized), 0.22.x (Nightly Channel) Jan 30, 2018
@bbondy bbondy modified the milestones: 0.22.x (Developer Channel), 0.23.x (Nightly Channel) Feb 25, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
dev-setup priority/P5 Cosmetic. Spelling, copy, layout. New features (which should also be part of an initiative). QA/no-qa-needed release-notes/exclude
Projects
None yet
Development

No branches or pull requests

7 participants