Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Fixed memory leak when opening then closing a lot of tabs rapidly #8244

Closed
bbondy opened this issue Apr 12, 2017 · 3 comments
Closed

Fixed memory leak when opening then closing a lot of tabs rapidly #8244

bbondy opened this issue Apr 12, 2017 · 3 comments
Assignees
@bbondy
Labels
QA/checked-Linux QA/checked-macOS QA/checked-Win32 QA/checked-Win64 QA/test-plan-specified release-notes/include
Milestone
0.15.0

Comments

@bbondy
Copy link
Member

bbondy commented Apr 12, 2017 •
edited by luixxiul
Loading

Old title: Leak in app state change listener in frame #8244 (comment)

If you open 12 tabs without closing there's a warning in the window console dev tools about a possible leak (Shift+F8). This isn't a leak and is ok.

If you open and close 12 tabs in a row, open, close, open, close .... there is the same leak message.
This is actually a leak and should be fixed.
@bbondy bbondy added this to the 0.14.2 milestone Apr 12, 2017
@bbondy bbondy self-assigned this Apr 12, 2017
@bbondy bbondy closed this as completed in 62ac81a Apr 12, 2017
bbondy added a commit that referenced this issue Apr 12, 2017
@bbondy
Fix leak with change listeners in frame
657689d 
Auditors: @bridiver

Fix #8244

Auditors: @bridiver
@alexwykoff alexwykoff mentioned this issue Apr 14, 2017
Closed
82 tasks
@luixxiul luixxiul added QA/test-plan-required needs-info Another team member needs information from the PR/issue opener. QA/test-plan-specified release-notes/include QA/checked-Win32 and removed QA/test-plan-required needs-info Another team member needs information from the PR/issue opener. labels Apr 17, 2017
This was referenced Apr 17, 2017
Closed
Closed
Closed
Closed
@srirambv
Copy link
Collaborator

Still see this error message on Win x64 clean install.
image
image

@luixxiul
Copy link
Contributor

Are you sure that you did follow the 2nd one? ie.

If you open and close 12 tabs in a row, open, close, open, close .... there is the same leak message.
This is actually a leak and should be fixed.

@srirambv
Copy link
Collaborator

Will retest once more and confirm

@alexwykoff alexwykoff mentioned this issue Apr 25, 2017
Closed
@alexwykoff alexwykoff changed the title Leak in app state change listener in frame Fixed memory leak when opening then closing a lot of tabs rapidly Apr 25, 2017
@srirambv srirambv mentioned this issue Jun 27, 2017
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bbondy bbondy

Labels
QA/checked-Linux QA/checked-macOS QA/checked-Win32 QA/checked-Win64 QA/test-plan-specified release-notes/include
Projects
None yet
Milestone
0.15.0
Development

No branches or pull requests
5 participants
@bbondy @alexwykoff @luixxiul @cezaraugusto @srirambv