Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

minor: fix lint error #12947

Merged
merged 1 commit into from
Jan 31, 2018
Merged

minor: fix lint error #12947

merged 1 commit into from
Jan 31, 2018

Conversation

petemill
Copy link
Member

This one slipped by in #12909 - my pre-push hooks don't seem to be firing.

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.
  • Request a security/privacy review as needed. (Ask a Brave employee to help if you cannot access this document.)

Test Plan:

Reviewer Checklist:

  • Request a security/privacy review as needed if one was not already requested.

Tests

  • Adequate test coverage exists to prevent regressions
  • Tests should be independent and work correctly when run individually or as a suite ref
  • New files have MPL2 license header

@petemill petemill added this to the 0.22.x (Developer Channel) milestone Jan 31, 2018
@petemill petemill self-assigned this Jan 31, 2018
Copy link
Member

@darkdh darkdh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@NejcZdovc NejcZdovc merged commit 94e5e15 into master Jan 31, 2018
@petemill petemill deleted the fix/minor-lint branch January 31, 2018 21:04
@bbondy bbondy modified the milestones: 0.22.x (Developer Channel), 0.23.x (Nightly Channel) Feb 25, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants