This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 974
"npm run add add-simulated-synopsis-visits" does not work on master #11394
Labels
0.19.x
issue first seen in 0.19.x
dev-setup
feature/rewards
priority/P5
Cosmetic. Spelling, copy, layout. New features (which should also be part of an initiative).
QA/checked-Linux
QA/checked-macOS
QA/checked-Win64
QA/test-plan-specified
release-notes/exclude
Milestone
Comments
Removed bug label- there is not a bug with Brave. This extra functionality for testing is broken after recent changes to the ledger. I believe with the reworking, cc: @NejcZdovc |
bsclifton
added
the
priority/P5
Cosmetic. Spelling, copy, layout. New features (which should also be part of an initiative).
label
Oct 9, 2017
The script is actually useful to test the ledger table (such as displaying |
NejcZdovc
added a commit
to NejcZdovc/browser-laptop
that referenced
this issue
Nov 17, 2017
Resolves brave#11394 Auditors: Test Plan:
This was referenced Nov 23, 2017
checked on master and works nicely. |
Re-opening as this doesn't seem to be working... @bsclifton also confirmed that it wasn't working for him.. STR:
Checked both macOS 10.13.1 x64 & Ubuntu 17.10 x64:
@luixxiul when you ran this on Debian, did the ledger table get populated? Maybe we're doing something incorrectly? |
this was broken with the latest bat libraries |
NejcZdovc
added a commit
to NejcZdovc/browser-laptop
that referenced
this issue
Nov 29, 2017
Fixed recovery promotional removal Removes staging flag Fixes fake visits Resolves brave#12131 Resolves brave#12098 Resolves brave#11394 Auditors: Test Plan:
NejcZdovc
added a commit
to NejcZdovc/browser-laptop
that referenced
this issue
Nov 29, 2017
Fixed recovery promotional removal Removes staging flag Fixes fake visits Resolves brave#12131 Resolves brave#12098 Resolves brave#11394 Auditors: Test Plan:
NejcZdovc
added a commit
to NejcZdovc/browser-laptop
that referenced
this issue
Nov 29, 2017
Fixed recovery promotional removal Removes staging flag Fixes fake visits Resolves brave#12131 Resolves brave#12098 Resolves brave#11394 Auditors: Test Plan:
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
0.19.x
issue first seen in 0.19.x
dev-setup
feature/rewards
priority/P5
Cosmetic. Spelling, copy, layout. New features (which should also be part of an initiative).
QA/checked-Linux
QA/checked-macOS
QA/checked-Win64
QA/test-plan-specified
release-notes/exclude
Test plan
#12014 (comment)
Description
npm run add-simulated-synopsis-visits
does not work on master.Steps to Reproduce
npm run add-simulated-synopsis-visits
Actual result:
See above.
Expected result:
Reproduces how often: [What percentage of the time does it reproduce?]
Brave Version
about:brave info:
433e69f
Reproducible on current live release:
Additional Information
The text was updated successfully, but these errors were encountered: