Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Fixes broken fake synopsis visits #12014

Merged
merged 1 commit into from
Nov 17, 2017
Merged

Conversation

NejcZdovc
Copy link
Contributor

@NejcZdovc NejcZdovc commented Nov 17, 2017

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.

Resolves #11394

Auditors:

Test Plan:

  1. crate clean profile
  2. close browser
  3. run npm run add-simulated-synopsis-visits
  4. start browser
  5. enable payments
  6. ledger table should be populated

Reviewer Checklist:

Tests

  • Adequate test coverage exists to prevent regressions
  • Tests should be independent and work correctly when run individually or as a suite ref
  • New files have MPL2 license header

Resolves brave#11394

Auditors:

Test Plan:
@codecov-io
Copy link

codecov-io commented Nov 17, 2017

Codecov Report

Merging #12014 into master will decrease coverage by 0.03%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #12014      +/-   ##
==========================================
- Coverage   53.34%    53.3%   -0.04%     
==========================================
  Files         274      274              
  Lines       26007    26007              
  Branches     4168     4168              
==========================================
- Hits        13873    13864       -9     
- Misses      12134    12143       +9
Flag Coverage Δ
#unittest 53.3% <ø> (-0.04%) ⬇️
Impacted Files Coverage Δ
js/stores/appStoreRenderer.js 91.17% <0%> (-8.83%) ⬇️
app/renderer/components/reduxComponent.js 84.37% <0%> (-6.25%) ⬇️
js/stores/windowStore.js 26.71% <0%> (-0.3%) ⬇️

Copy link
Contributor

@luixxiul luixxiul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The test plan works.

@bsclifton bsclifton merged commit 49f329d into brave:master Nov 17, 2017
bsclifton added a commit that referenced this pull request Nov 17, 2017
bsclifton added a commit that referenced this pull request Nov 17, 2017
bsclifton added a commit that referenced this pull request Nov 17, 2017
@bsclifton
Copy link
Member

master 49f329d
0.21.x 735ef51
0.20.x 3d89d19
0.19.x 9c77f59

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"npm run add add-simulated-synopsis-visits" does not work on master
4 participants