-
Notifications
You must be signed in to change notification settings - Fork 974
Conversation
dd1bf4c
to
0a52f97
Compare
Codecov Report
@@ Coverage Diff @@
## master #12136 +/- ##
==========================================
- Coverage 55.03% 54.93% -0.11%
==========================================
Files 275 275
Lines 26497 26549 +52
Branches 4258 4270 +12
==========================================
+ Hits 14582 14584 +2
- Misses 11915 11965 +50
|
Edit: works fine when run with |
Looks good on MacOS |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested utilizing the test plan specified and LEDGER_ENVIRONMENT=staging npm run start
and tests were as expected.
js/actions/appActions.js
Outdated
dispatch({ | ||
actionType: appConstants.APP_ON_PROMOTION_RESPONSE | ||
actionType: appConstants.APP_ON_PROMOTION_RESPONSE, | ||
error |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are we wanting to call this error? It seems like this also contains the success response?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
renamed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look great! 😄 Comment left about one field which I think could be named better. Otherwise 👍
Fixed recovery promotional removal Removes staging flag Fixes fake visits Resolves brave#12131 Resolves brave#12098 Resolves brave#11394 Auditors: Test Plan:
0a52f97
to
17be9ba
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code changes look great! 👍 Thanks for updating the response param name 😄
Adds some additional banners
Adds some additional banners
master 81f7991 |
Adds some additional banners
0.19.x 23d2f5a |
This PR switches promotions to the production server!!
Please test this PR with
LEDGER_ENVIRONMENT=staging npm run start
, so that you will still be using staging.Submitter Checklist:
git rebase -i
to squash commits (if needed).Fixed recovery promotional removal
Removes staging flag
Fixes fake visits
Resolves #12131
Resolves #12098
Resolves #11394
Auditors:
Test Plan:
a) Regular promotion
b) Network problem
Reviewer Checklist:
Tests