-
Notifications
You must be signed in to change notification settings - Fork 974
Disabling Torrent Viewer doesn't disable Torrent Handling #10767
Comments
I remember @srirambv maybe has reported a similar issue for a while ago. |
+1 Linuxmint 64 bit |
Still exists in |
FYI: still exists in Brave: 0.19.24 |
@vaguiners let's keep it civil in here please. I would like this issue fixed too, but let's refrain from using nasty language |
Still present in 0.20.30, release channel |
The torrent file is actually downloaded in 0.20.30 though, so it is not that problematic. But since #11452 is fixed, I'll try to reenable the plugin. |
Still exists:
|
|
Still not working and seems worse than ever. I even cannot save a torrent file, I have to start chromium to be able to download a torrent file.
|
+1 |
It is sad to not be able to use the browser because you can't download a plain torrent file. |
Resolves brave#10767 Auditors: Test Plan:
@bsclifton can we include this into https://github.com/brave/browser-laptop/milestone/114? @NejcZdovc has a PR ready and we've gotten a good amount of folks from the community that would like this fixed as well. |
Fixes disabled torrent viewer torrent download
Fixes disabled torrent viewer torrent download
Fixes disabled torrent viewer torrent download
@bsclifton @NejcZdovc does the fix for the issue removes handling of .torrent files? With Torrent viewer enabled in extensions, clicking a .torrent file used load it in the tab for download but not any more. Is this expected? |
@srirambv so torrent viewer is not loaded anymore if you have it enabled? |
@NejcZdovc yes correct |
let me try it |
@srirambv yes it's a problem and will fix it |
Resolves brave#10767 Auditors: Test Plan:
Verified on Windows x64 with
Verified with macOS 10.12.6 using
Verified on Ubuntu 17.10 x64
|
Test plan
Torrent Viewer
(if not already disabled)Torrent
buttonOriginal issue description
Did you search for similar issues before submitting this one?
Yes
Describe the issue you encountered:
Brave's native handling of .torrent files can be problematic for some sites (#10672). In an attempt to work around this issue, I sought to disable the built-in Web Torrent extension. Unfortunately, Brave still attempts to pass .torrent requests off to Web Torrent, which is unavailable after being disabled.
Platform (Win7, 8, 10? macOS? Linux distro?):
Desktop
Brave Version (revision SHA):
0.18.23 (36ae2ec)
Steps to reproduce:
Actual result:
Brave attempts to handle torrent requests long after Torrent Viewer has been disabled.
Expected result:
Disabling Torrent Viewer causes Brave to leave .torrent requests alone.
Will the steps above reproduce in a fresh profile? If not what other info can be added?
Yes
Is this an issue in the currently released version?
Yes
Can this issue be consistently reproduced?
Yes
Screenshot if needed:
Any related issues:
#10672
The text was updated successfully, but these errors were encountered: