This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
Fixes disabled torrent viewer torrent download #14134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NejcZdovc
commented
May 15, 2018
js/stores/appStore.js
Outdated
| @@ -202,6 +204,14 @@ const applyReducers = (state, action, immutableAction) => reducers.reduce( | |||
| return newState | |||
| }, appState) | |||
|
|
|||
| const isWebTorrentEnabled = (state) => { | |||
There was a problem hiding this comment.
Place of this function is not perfect. Where would you put it, so that I can also add unit tests?
There was a problem hiding this comment.
@NejcZdovc how about app/common/state/extensionState.js?
There was a problem hiding this comment.
I was thinking about that file but was not sure. Ok let me put it there. Thx
There was a problem hiding this comment.
that is a perfect place to put it- good call 😄
bsclifton
modified the milestones:
0.24.x (Nightly Channel),
0.22.x Release 4 (Beta channel)
NejcZdovc
force-pushed
the
fix/#10767-torrent
branch
from
3d6763e to
a735504
Compare
Resolves brave#10767 Auditors: Test Plan:
NejcZdovc
force-pushed
the
fix/#10767-torrent
branch
from
a735504 to
a4584cf
Compare
bsclifton
approved these changes
May 21, 2018
bsclifton
added a commit
that referenced
this pull request
May 21, 2018
Fixes disabled torrent viewer torrent download
bsclifton
added a commit
that referenced
this pull request
May 21, 2018
Fixes disabled torrent viewer torrent download
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #10767
Submitter Checklist:
git rebase -ito squash commits (if needed).Test Plan:
Reviewer Checklist:
Tests