Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Fixes WebTorrent not being enabled #14218

Merged
merged 1 commit into from
May 23, 2018
Merged

Conversation

NejcZdovc
Copy link
Contributor

@NejcZdovc NejcZdovc commented May 23, 2018

Resolves #10767

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.
  • Request a security/privacy review as needed. (Ask a Brave employee to help if you cannot access this document.)

Test Plan:

  • clean profile
  • go to https://webtorrent.io/free-torrents/
  • try to download torrent file and try to click on magnet link
  • make sure that is handled by the WebTorrent
  • go to extension page and disable WebTorrent
  • go to https://webtorrent.io/free-torrents/
  • try to download torrent file and try to click on magnet link
  • make sure that file is downloaded and that you see handler for the link
  • go to extension page and enable WebTorrent
  • try to download torrent file and try to click on magnet link
  • make sure that is handled by the WebTorrent

Reviewer Checklist:

  • Request a security/privacy review as needed if one was not already requested.

Tests

  • Adequate test coverage exists to prevent regressions
  • Tests should be independent and work correctly when run individually or as a suite ref
  • New files have MPL2 license header

Resolves brave#10767

Auditors:

Test Plan:
@NejcZdovc NejcZdovc added this to the 0.22.x Release 4 (Beta channel) milestone May 23, 2018
@NejcZdovc NejcZdovc self-assigned this May 23, 2018
Copy link
Member

@bsclifton bsclifton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great! Here is where it all originally went downhill:
NejcZdovc@c050f3b

Code changes look good- test plan works great! 😄 👍

@bsclifton bsclifton merged commit 285ca53 into brave:master May 23, 2018
bsclifton added a commit that referenced this pull request May 23, 2018
Fixes WebTorrent not being enabled
bsclifton added a commit that referenced this pull request May 23, 2018
Fixes WebTorrent not being enabled
@bsclifton
Copy link
Member

master 285ca53
0.23.x 03e86dd
0.22.x 8e7bbbb

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants