Open a bookmark item in a foreground tab

If SWITCH_TO_NEW_TABS is truthy (or if Shift key is pressed: this is the
current behavior)

Auditors: @bsclifton

Test Plan:
  - Simulate middle clicking a bookmark item
  - Check that a new foreground tab is opened with the same URL as that of the
  bookmark (or just check that if such an event is fired if a URL check is not
  feasible)

Fix #3207.

js/actions/bookmarkActions.js

@@ -7,6 +7,8 @@
 const siteUtil = require('../state/siteUtil')
 const windowActions = require('./windowActions')
 const eventUtil = require('../lib/eventUtil')
+const {SWITCH_TO_NEW_TABS} = require('../constants/settings')
+const getSetting = require('../settings').getSetting
 
 const bookmarkActions = {
   openBookmarksInFolder: function (allBookmarkItems, folderDetail) {
@@ -17,7 +19,7 @@ const bookmarkActions = {
     // Only load the first 25 tabs as loaded
     bookmarks
       .forEach((bookmark, i) =>
-        windowActions.newFrame(Object.assign(siteUtil.toFrameOpts(bookmark), {unloaded: i > 25}), false))
+        windowActions.newFrame(Object.assign(siteUtil.toFrameOpts(bookmark), {unloaded: i > 25}), getSetting(SWITCH_TO_NEW_TABS)))
   },
 
   /**
@@ -31,7 +33,7 @@ const bookmarkActions = {
         windowActions.newFrame({
           location: bookmarkItem.get('location'),
           partitionNumber: bookmarkItem && bookmarkItem.get && bookmarkItem.get('partitionNumber') || undefined
-        }, !!e.shiftKey)
+        }, !!e.shiftKey || getSetting(SWITCH_TO_NEW_TABS))
       } else {
         windowActions.loadUrl(activeFrame, bookmarkItem.get('location'))
       }