Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Middle click on a bookmark link opens tab in the background #3207

Closed
ghost opened this issue Aug 16, 2016 · 2 comments · Fixed by #5831
Closed

Middle click on a bookmark link opens tab in the background #3207

ghost opened this issue Aug 16, 2016 · 2 comments · Fixed by #5831
Labels
bug/good-first-bug feature/bookmarks QA/checked-Win32 QA/checked-Win64 QA/test-plan-specified release-notes/include
Milestone
0.13.0

Comments

@ghost
Copy link

ghost commented Aug 16, 2016

Did you search for similar issues before submitting this one?
Yes

Describe the issue you encountered:
When "Switch to new tabs immediately" setting has been selected, middle clicking on a bookmark link opens a new tab in the background.

Expected behavior:
The new tab should open in the foreground, like with right clicking and selecting "Open Link in New Tab".

  • Platform (Win7, 8, 10? macOS? Linux distro?): Windows 7, Ubuntu 16.04 LTS
  • Brave Version: 0.11.5
  • Steps to reproduce:
    1. Go to settings and turn on "Switch to new tabs immediately";
    2. Middle click on a link in the bookmarks toolbar;
    3. New tab opens in the background, not foreground.
  • Screenshot if needed:
  • Any related issues:
@bsclifton
Copy link
Member

Possibly related:
#3068

GreenRecycleBin added a commit to GreenRecycleBin/browser-laptop that referenced this issue Nov 24, 2016
@GreenRecycleBin
Open a bookmark item in a foreground tab
3658897 
If SWITCH_TO_NEW_TABS is truthy (or if Shift key is pressed: this is the
current behavior)

Auditors: Unsure what to fill in here

Test Plan:
  - Simulate middle clicking a bookmark item
  - Check that a new foreground tab is opened with the same URL as that of the
  bookmark (or just check that if such an event is fired if a URL check is not
  feasible)

Fix brave#3207.
@GreenRecycleBin GreenRecycleBin mentioned this issue Nov 24, 2016
Merged
bsclifton pushed a commit to GreenRecycleBin/browser-laptop that referenced this issue Nov 26, 2016
@GreenRecycleBin @bsclifton
Open a bookmark item in a foreground tab
87d9bf2 
If SWITCH_TO_NEW_TABS is truthy (or if Shift key is pressed: this is the
current behavior)

Auditors: @bsclifton

Test Plan:
  - Simulate middle clicking a bookmark item
  - Check that a new foreground tab is opened with the same URL as that of the
  bookmark (or just check that if such an event is fired if a URL check is not
  feasible)

Fix brave#3207.
@bsclifton bsclifton added this to the 0.13.0 milestone Nov 26, 2016
This was referenced Dec 12, 2016
Closed
Closed
This was referenced Dec 20, 2016
Closed
Closed
Closed
Closed
@alexwykoff alexwykoff mentioned this issue Dec 20, 2016
Closed
@luixxiul
Copy link
Contributor

Test plan: specified in 87d9bf2

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug/good-first-bug feature/bookmarks QA/checked-Win32 QA/checked-Win64 QA/test-plan-specified release-notes/include
Projects
None yet
Milestone
0.13.0
Development

Successfully merging a pull request may close this issue.

Open bookmarks in new foreground tabs GreenRecycleBin/browser-laptop
3 participants
@luixxiul @bsclifton @srirambv