Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed duplicated peers list title #9005

Merged
merged 1 commit into from
Jun 4, 2021
Merged

Removed duplicated peers list title #9005

merged 1 commit into from
Jun 4, 2021

Conversation

spylogsster
Copy link
Contributor

@spylogsster spylogsster commented Jun 3, 2021

Resolves brave/brave-browser#16129

image

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

  • open peers list and check titles

@spylogsster spylogsster requested a review from bbondy June 3, 2021 09:12
@spylogsster spylogsster self-assigned this Jun 3, 2021
@bbondy
Copy link
Member

bbondy commented Jun 3, 2021

Do we need a title at all there? Does it look awkward without a title?

@spylogsster
Copy link
Contributor Author

spylogsster commented Jun 3, 2021

image
@bbondy @stephendonner

@bbondy
Copy link
Member

bbondy commented Jun 3, 2021

Looks like the line is attached to the button. If it's easier I'm ok back with the fixed title.

@spylogsster
Copy link
Contributor Author

spylogsster commented Jun 4, 2021

@bbondy it was just for demo, updated images and pushed code

@spylogsster spylogsster changed the title Changed peers list title Removed duplicated peers list title Jun 4, 2021
@bbondy bbondy merged commit 5dd8676 into master Jun 4, 2021
@bbondy bbondy deleted the issue-16129 branch June 4, 2021 18:01
@bbondy bbondy added this to the 1.27.x - Nightly milestone Jun 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"The peers list" heading in IPFS needs rewording
2 participants